chore: use actual circuit size in sumcheck #20301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakovenkos
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
fcarreiro
reviewed
Feb 9, 2026
| size_t AvmProver::compute_actual_circuit_size() const | ||
| { | ||
| size_t actual_size = 0; | ||
| for (const auto& poly : prover_polynomials.get_unshifted()) { |
Contributor
There was a problem hiding this comment.
Shouldn't we use the witnesses only (at least for sumcheck)? In this PR: #20209 I used compute_effective_* that you guys have which does that.
Contributor
Author
There was a problem hiding this comment.
Ah, I overlooked your PR. Should be equivalent I think apart from the fact that you're paying for GateSeparatorPolynomial<FF> gate_separators(gate_challenges, multivariate_d);
as you'd feed
Contributor
There was a problem hiding this comment.
Passing the real size to sumcheck sgtm. In compute univariates I think we are a bit tighter because we dont need to make it a power of 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental