chore!: use standard serialization order for public data hash inputs #20291
+1,928
−1,887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeilaWang
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
LeilaWang
requested review from
iAmMichaelConnor
and removed request for
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
LeilaWang
force-pushed
the
lw/public_data_hash_inputs
branch
from
e5cd87a to
166bcd2
Compare
LeilaWang
force-pushed
the
lw/public_data_hash_inputs
branch
from
166bcd2 to
40c6c6c
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
iAmMichaelConnor
approved these changes
Feb 10, 2026
Contributor
iAmMichaelConnor
left a comment
iAmMichaelConnor
left a comment
There was a problem hiding this comment.
Approving protocol circuits and ts, but I'm too unfamiliar with AVM to approve those changes (even though it looks correct)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We normally use
hash(T::serialize())to compute the hash of T. This pr updates the hash ofPublicDataLeafPreimageto follow the same approach.