feat(token): emit Transfer event on public transfer #20198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-mitch
force-pushed
the
mitch/f-296-token-contract-to-support-public-logs-on-transfer
branch
from
621d961 to
7886138
Compare
gniumg-source
added a commit
to gniumg-source/aztec-packages
that referenced
this pull request
Feb 9, 2026
Closed
just-mitch
force-pushed
the
mitch/f-296-token-contract-to-support-public-logs-on-transfer
branch
from
7886138 to
ea64007
Compare
wei3erHase
reviewed
Feb 10, 2026
Comment on lines
46
to
51
| const events = await getDecodedPublicEvents<Transfer>( | ||
| t.node, | ||
| TokenContract.events.Transfer, | ||
| receipt.blockNumber!, | ||
| 1, | ||
| ); |
There was a problem hiding this comment.
interesting, i wasn't aware of getDecodedPublicEvents method, isn't filtering by block number and limit quite fragile? at least on production seems like it would be inconvenient, why not use txHash?
Collaborator
Author
There was a problem hiding this comment.
My motivating use case was around being able to scan blocks for these events, so I didn't want to assume I had access to the TxHash.
You're definitely right though that this would be fragile as written in prod, since the contents of the blocks would be subject to reorg until proven, so the polling code would need to be aware of that.
There was a problem hiding this comment.
adding feature request related to this: #20332
just-mitch
force-pushed
the
mitch/f-296-token-contract-to-support-public-logs-on-transfer
branch
from
ea64007 to
4264ed4
Compare
Collaborator
Author
Compile (Noir contracts)TypeScript validationAction required: Please fix the docs examples or update them to match the current API. cc @AztecProtocol/devrel |
just-mitch
force-pushed
the
mitch/f-296-token-contract-to-support-public-logs-on-transfer
branch
2 times, most recently
from
f7c5510 to
700c04b
Compare
Also accounts for private transfers (burn, mint, transfer_to_private, transfer_to_public). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
just-mitch
force-pushed
the
mitch/f-296-token-contract-to-support-public-logs-on-transfer
branch
from
700c04b to
1a30c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
self.emit(Transfer { from, to, amount })to all balance changesCloses F-296