fix(ci): resolve Biome lint errors breaking CI pipeline#48
Merged
Conversation
- Update biome.json schema to 2.4.6 and enable Tailwind CSS directives - Configure VCS-aware linting and downgrade pre-existing lint warnings - Fix forEach callback return values (useIterableCallbackReturn) - Add type="button" to button elements (useButtonType) - Fix useRecentRepos hook declaration order (noInvalidUseBeforeDeclaration) - Prefix unused destructured variables with underscore - Auto-format renovate.json and index.css per Biome rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biome.jsonto schema v2.4.6, enables Tailwind CSS@themedirective parsing, and configures VCS-aware lintingnoExplicitAny,noNonNullAssertion,noArrayIndexKey, and several a11y rules) from error to warning level so CI can pass while these are incrementally addresseduseIterableCallbackReturninregistry.tsandBranchItem.tsx,useButtonTypeinWorkflowNavigation.tsxandviewer3d-standalone.html,noInvalidUseBeforeDeclaration+useExhaustiveDependenciesinuseRecentRepos.ts, unused variables inBranchList.tsxrenovate.jsonandsrc/index.cssper Biome rulesThis unblocks the CI for
mainand both Renovate PRs (#44, #46) which fail on the samelint-and-testjob. After merging, those PRs should be rebased.Test plan
npx biome check .exits with code 0 (no errors, only warnings)lint-and-testjob passes on this branch