feat: add phpat and remove phpmd

.github/workflows/php.code_quality.yaml

@@ -34,7 +34,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        tool: [phpcs, phpmd, phpstan, phpunit]
+        tool: [phpcs, phpstan, phpunit]
     steps:
       - name: Setup PHP ${{ env.PHP_VERSION }} environment
         uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401

README.md

@@ -5,7 +5,7 @@ This is the coding style tools config I use everyday on my projects.
 it includes :
 - PHPCS for code sniffing.
 - PHPStan for static bug finding into code.
-- PHPMD for static performance analysis (complexity, unused expressions, optimizing).
+- PHPAt as phpstan extension for architecture validation
 
 ## Installation
 
@@ -49,26 +49,16 @@ Run it with :
 $ ./vendor/bin/phpstan analyse --level=max src
 ```
 
-### PHPMD
+### PHPAT
 
-In your project, create a `phpmd.xml` file and fill it up with :
+Validate Architecture.
 
-```xml
-<?xml version="1.0"?>
-<ruleset name="Arty ruleset"
-         xmlns="http://pmd.sf.net/ruleset/1.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
-         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
-    <description>
-        Arty ruleset
-    </description>
-
-    <rule ref="./vendor/arty/php-coding-standard/lib/phpmd/phpmd.xml"/>
-</ruleset>
-```
+A minimal Clean Architecture validation is provided, activate it by adding this to your phpstan.neon:
 
-Run it with :
-```bash
-$ ./vendor/bin/phpmd src text phpmd.xml
+```neon
+services:
+    -
+        class: ArtyCodingStandard\PHPAt\CleanArchitectureTest
+        tags:
+            - phpat.test
 ```

composer.json

@@ -7,9 +7,9 @@
     "php": "^8.4",
     "squizlabs/php_codesniffer": "^4.0",
     "slevomat/coding-standard": "^8.24",
-    "phpmd/phpmd": "^2.15",
     "phpstan/phpstan": "^2.1",
-    "phpstan/phpstan-symfony": "^2.0"
+    "phpstan/phpstan-symfony": "^2.0",
+    "phpat/phpat": "^0.12.3"
   },
   "require-dev": {
     "roave/security-advisories": "dev-latest",

phpstan.neon

@@ -2,6 +2,7 @@ includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon
     - vendor/phpstan/phpstan-phpunit/rules.neon
     - lib/phpstan/phpstan.neon
+    - vendor/phpat/phpat/extension.neon
 
 parameters:
 	bootstrapFiles:

src/ArtyCodingStandard/PHPAt/CleanArchitectureTest.php

@@ -0,0 +1,78 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ArtyCodingStandard\PHPAt;
+
+use PHPat\Selector\Selector;
+use PHPat\Test\Builder\Rule;
+use PHPat\Test\PHPat;
+
+final class CleanArchitectureTest
+{
+    public function testDomainDoesNotDependOnApplication(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Domain'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('App\Application'))
+            ->because('Domain is the core layer and must remain independent of outer layers');
+    }
+
+    public function testDomainDoesNotDependOnInfrastructure(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Domain'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('App\Infrastructure'))
+            ->because('Domain must not know about infrastructure concerns (DB, HTTP, etc.)');
+    }
+
+    public function testDomainDoesNotDependOnSymfony(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Domain'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('Symfony'))
+            ->because('Domain must be framework-agnostic');
+    }
+
+    public function testDomainDoesNotDependOnDoctrine(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Domain'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('Doctrine'))
+            ->because('Domain must not depend on persistence concerns');
+    }
+
+    public function testApplicationDoesNotDependOnInfrastructure(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Application'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('App\Infrastructure'))
+            ->because('Application layer must depend on Domain abstractions, not Infrastructure implementations');
+    }
+
+    public function testApplicationDoesNotDependOnSymfony(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Application'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('Symfony'))
+            ->because('Application use-cases must be framework-agnostic');
+    }
+
+    public function testApplicationDoesNotDependOnDoctrine(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::inNamespace('App\Application'))
+            ->shouldNotDependOn()
+            ->classes(Selector::inNamespace('Doctrine'))
+            ->because(
+                'Application layer must not depend on persistence concerns'
+                . ' — use Domain repository interfaces instead',
+            );
+    }
+}