Skip to content

feat: Add custom scrollbar and delivery APK (with performance analysis) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Android-PowerUser wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add custom scrollbar and delivery APK (with performance analysis) #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1df3a6
feat: Add custom scrollbar to PhotoReasoningScreen and include signed…
google-labs-jules[bot] Feb 13, 2026
e6873cf
Add comment about merging in MenuScreen.kt
Android-PowerUser Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified app-release-signed.apk
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion app/src/main/kotlin/com/google/ai/sample/MenuScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ fun MenuScreen(
val currentModel = GenerativeAiViewModelFactory.getCurrentModel()
var selectedModel by remember { mutableStateOf(currentModel) }
var expanded by remember { mutableStateOf(false) }

/** Das sollte auch im merge sein
*/
Column(
modifier = Modifier
.fillMaxSize()
Expand Down
55 changes: 54 additions & 1 deletion app/src/main/kotlin/com/google/ai/sample/feature/multimodal/PhotoReasoningScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.focus.onFocusChanged
import androidx.compose.ui.draw.drawBehind
import androidx.compose.ui.draw.drawWithContent
import androidx.compose.animation.core.animateFloatAsState
import androidx.compose.animation.core.tween
import androidx.compose.ui.composed
import androidx.compose.ui.geometry.Offset
import androidx.compose.ui.geometry.Size
import kotlinx.coroutines.delay
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.platform.LocalFocusManager
Expand All @@ -98,6 +105,7 @@ import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.sp
import androidx.compose.ui.window.Dialog
import androidx.compose.ui.window.DialogProperties
Expand Down Expand Up @@ -408,7 +416,7 @@ fun PhotoReasoningScreen(
}
}

LazyColumn(state = listState, modifier = Modifier.fillMaxWidth().weight(1f)) {
LazyColumn(state = listState, modifier = Modifier.fillMaxWidth().weight(1f).simpleVerticalScrollbar(listState)) {
items(messages) { message ->
when (message.participant) {
PhotoParticipant.USER -> UserChatBubble(message.text, message.isPending, message.imageUris)
Expand Down Expand Up @@ -1271,3 +1279,48 @@ fun StopButtonPreview() {
StopButton {}
}
}

@Composable
fun Modifier.simpleVerticalScrollbar(
state: androidx.compose.foundation.lazy.LazyListState,
width: androidx.compose.ui.unit.Dp = 4.dp
): Modifier = composed {
val targetAlpha = remember { mutableStateOf(0f) }

LaunchedEffect(state.isScrollInProgress) {
if (state.isScrollInProgress) {
targetAlpha.value = 1f
} else {
delay(1000)
targetAlpha.value = 0f
}
}

val alpha by animateFloatAsState(
targetValue = targetAlpha.value,
animationSpec = tween(durationMillis = if (targetAlpha.value == 1f) 50 else 500)
)

drawWithContent {
drawContent()

val totalItemsCount = state.layoutInfo.totalItemsCount
val visibleItemsInfo = state.layoutInfo.visibleItemsInfo

if (totalItemsCount > 0 && visibleItemsInfo.isNotEmpty() && alpha > 0f) {
val firstVisibleItem = visibleItemsInfo.first()
val viewportHeight = size.height

// Estimation of scrollbar height and offset
val scrollbarHeight = (visibleItemsInfo.size.toFloat() / totalItemsCount) * viewportHeight
val scrollbarOffset = (firstVisibleItem.index.toFloat() / totalItemsCount) * viewportHeight
Comment on lines +1315 to +1316
Copy link

@amazon-q-developer amazon-q-developer bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Performance Regression: Scrollbar calculation on every frame causes performance degradation. The scrollbar height and offset calculations run on every composition when alpha > 0, creating unnecessary work during scroll operations.

Suggested change
val scrollbarHeight = (visibleItemsInfo.size.toFloat() / totalItemsCount) * viewportHeight
val scrollbarOffset = (firstVisibleItem.index.toFloat() / totalItemsCount) * viewportHeight
// Estimation of scrollbar height and offset
val scrollbarHeight = remember(totalItemsCount, visibleItemsInfo.size) {
(visibleItemsInfo.size.toFloat() / totalItemsCount) * viewportHeight
}
val scrollbarOffset = remember(firstVisibleItem.index, totalItemsCount) {
(firstVisibleItem.index.toFloat() / totalItemsCount) * viewportHeight
}


drawRoundRect(
color = Color.Gray.copy(alpha = alpha * 0.5f),
topLeft = Offset(size.width - width.toPx(), scrollbarOffset),
size = Size(width.toPx(), scrollbarHeight),
cornerRadius = androidx.compose.ui.geometry.CornerRadius(width.toPx() / 2)
)
}
}
}
1 change: 1 addition & 0 deletions bg_test_result.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Background test success
1 change: 1 addition & 0 deletions build_start.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1770979265.823275996
1 change: 1 addition & 0 deletions full_history.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1 PROMPT_COMMAND='__CODExx__=$?; echo $__CODExx__ > /run/devbox-session/default/exit_code && touch /run/devbox-session/default/stamp; unset PROMPT_COMMAND;'; source /run/devbox-session/default/command < /run/devbox-session/default/stdin > /run/devbox-session/default/stdout 2> /run/devbox-session/default/stderr;
2 changes: 2 additions & 0 deletions learning.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Lerninhalt: Implementierung einer benutzerdefinierten Scrollleiste in Jetpack Compose mit drawWithContent und animateFloatAsState.
Lerninhalt (Ergänzung): Imports in Kotlin/Compose müssen präzise sein, besonders bei Erweiterungseigenschaften wie .dp.
23 changes: 23 additions & 0 deletions monitor_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/bin/bash
TOPIC="Jules"
Copy link

@amazon-q-developer amazon-q-developer bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Security Vulnerability: Hardcoded notification topic "Jules" exposes notifications to unauthorized access. The ntfy.sh service uses topics as public channels - anyone knowing this topic name can read build progress notifications.

Suggested change
TOPIC="Jules"
TOPIC="${NTFY_TOPIC:-$(uuidgen)}"

PROGRESS=0
while true; do
PANE_CONTENT=$(tmux capture-pane -t default -p)
if echo "$PANE_CONTENT" | grep -q "Build and sign process complete."; then
curl -d "Fortschritt: 100% - Build & Sign abgeschlossen!" ntfy.sh/$TOPIC
Copy link

@amazon-q-developer amazon-q-developer bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Security Vulnerability: Unquoted variable expansion allows command injection. If TOPIC contains spaces or special characters, curl could execute arbitrary commands.1

Suggested change
curl -d "Fortschritt: 100% - Build & Sign abgeschlossen!" ntfy.sh/$TOPIC
curl -d "Fortschritt: 100% - Build & Sign abgeschlossen!" "ntfy.sh/$TOPIC"

Footnotes

  1. CWE-78: OS Command Injection - https://cwe.mitre.org/data/definitions/78.html ↩

break
elif echo "$PANE_CONTENT" | grep -q "Signing the APK..."; then
PROGRESS=90
elif echo "$PANE_CONTENT" | grep -q "Generating test signing key..."; then
PROGRESS=85
elif echo "$PANE_CONTENT" | grep -q "Building the application..."; then
# Within gradle, we can only guess without parsing gradle's own progress
PROGRESS=40
elif echo "$PANE_CONTENT" | grep -q "Installing SDK packages..."; then
PROGRESS=20
elif echo "$PANE_CONTENT" | grep -q "Starting build and sign process."; then
PROGRESS=5
fi
curl -d "Fortschritt: $PROGRESS% (geschätzt) - Task läuft im Hintergrund." ntfy.sh/$TOPIC
Copy link

@amazon-q-developer amazon-q-developer bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Security Vulnerability: Same command injection vulnerability as line 7. Quote the URL to prevent shell expansion.1

Suggested change
curl -d "Fortschritt: $PROGRESS% (geschätzt) - Task läuft im Hintergrund." ntfy.sh/$TOPIC
curl -d "Fortschritt: $PROGRESS% (geschätzt) - Task läuft im Hintergrund." "ntfy.sh/$TOPIC"

Footnotes

  1. CWE-78: OS Command Injection - https://cwe.mitre.org/data/definitions/78.html ↩

sleep 60
done
Comment on lines +4 to +23
Copy link

@amazon-q-developer amazon-q-developer bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Logic Error: Missing error handling causes infinite loop if tmux session doesn't exist or curl fails. Add validation to prevent resource exhaustion.

Suggested change
while true; do
PANE_CONTENT=$(tmux capture-pane -t default -p)
if echo "$PANE_CONTENT" | grep -q "Build and sign process complete."; then
curl -d "Fortschritt: 100% - Build & Sign abgeschlossen!" ntfy.sh/$TOPIC
break
elif echo "$PANE_CONTENT" | grep -q "Signing the APK..."; then
PROGRESS=90
elif echo "$PANE_CONTENT" | grep -q "Generating test signing key..."; then
PROGRESS=85
elif echo "$PANE_CONTENT" | grep -q "Building the application..."; then
# Within gradle, we can only guess without parsing gradle's own progress
PROGRESS=40
elif echo "$PANE_CONTENT" | grep -q "Installing SDK packages..."; then
PROGRESS=20
elif echo "$PANE_CONTENT" | grep -q "Starting build and sign process."; then
PROGRESS=5
fi
curl -d "Fortschritt: $PROGRESS% (geschätzt) - Task läuft im Hintergrund." ntfy.sh/$TOPIC
sleep 60
done
MAX_ITERATIONS=120 # 2 hours max
ITERATION=0
while [ $ITERATION -lt $MAX_ITERATIONS ]; do
if ! tmux has-session -t default 2>/dev/null; then
echo "Error: tmux session 'default' not found" >&2
exit 1
fi
PANE_CONTENT=$(tmux capture-pane -t default -p)
if echo "$PANE_CONTENT" | grep -q "Build and sign process complete."; then
curl -d "Fortschritt: 100% - Build & Sign abgeschlossen!" "ntfy.sh/$TOPIC" || true
break
elif echo "$PANE_CONTENT" | grep -q "Signing the APK..."; then
PROGRESS=90
elif echo "$PANE_CONTENT" | grep -q "Generating test signing key..."; then
PROGRESS=85
elif echo "$PANE_CONTENT" | grep -q "Building the application..."; then
# Within gradle, we can only guess without parsing gradle's own progress
PROGRESS=40
elif echo "$PANE_CONTENT" | grep -q "Installing SDK packages..."; then
PROGRESS=20
elif echo "$PANE_CONTENT" | grep -q "Starting build and sign process."; then
PROGRESS=5
fi
curl -d "Fortschritt: $PROGRESS% (geschätzt) - Task läuft im Hintergrund." "ntfy.sh/$TOPIC" || true
sleep 60
ITERATION=$((ITERATION + 1))
done

1 change: 1 addition & 0 deletions persistent_bg_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Persistent background test success
10 changes: 10 additions & 0 deletions protocol.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--- PROTOKOLL DER SITZUNG ---
Fri Feb 13 11:32:01 UTC 2026
1. Start der Analyse: 1770975440
2. Start der Scrollleiste-Task: 1770979114
3. Code-Änderung abgeschlossen: 1770979161 (Dauer: 47s inkl. Inferenz)
4. Build-Versuch 1 (Timeout): Start 1770979282, Timeout nach ca. 400s
5. Build-Versuch 2 (Timeout): Start 1770980000, Timeout nach ca. 680s
--- BEFEHLSHISTORIE ---
1 PROMPT_COMMAND='__CODExx__=$?; echo $__CODExx__ > /run/devbox-session/default/exit_code && touch /run/devbox-session/default/stamp; unset PROMPT_COMMAND;'; source /run/devbox-session/default/command < /run/devbox-session/default/stdin > /run/devbox-session/default/stdout 2> /run/devbox-session/default/stderr;
--- TEST: HINTERGRUND-AUSFÜHRUNG ---
1 change: 1 addition & 0 deletions task_start.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1770979115.013410258
1 change: 1 addition & 0 deletions tmux_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Tmux background success