Merged
Conversation
…ent flavors and seeing how the tests would be marked and etc for each version
…g ever, need to remember how I tested it locally on maocs as the wheel name is defaulting to macos currently whichis no good
…official cibuildwheel action
…se issues so I think I just have to modify the root cspice cmake a bit or this one, but hoping to just edit this project for now
…red -Wl,-soname,libcspice.wasm ' that are not being set in this repo, but those lines are only added when on unix
…s something else going on causing the shared library not to be found
…is issue in my test repo
…g kernels for tests, really should test before this push locally
…, fixed some issues with __all__
…killing the process
…e work on that repo
…hings too difficult right now and isn't even a strong requirement
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 99.71% 99.61% -0.11%
==========================================
Files 17 17
Lines 17832 17893 +61
==========================================
+ Hits 17782 17824 +42
- Misses 50 69 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…de, some occasional flackey ness still seen but looking good otherwise
…mes but just failed on ci
Closed
…so consider merging and doing a new branch for more of these changes
AndrewAnnex
requested a deployment
to
testpypi
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new version of #516 where I disable cyice builds as not necessary for pyodide support