Conversation
This patch deduplicates the functions diff_timeval_us(), adjust_unit(), and print_header() as well as the macro UNUSED().
Although function msleep() is only used in libflow.c, it was in library utils. This patch moves msleep() to libflow.c.
Change short options for debug-real-size from 'r' (real) to 'a' (actual) and debug-wrap from 'w' (wrap) to 'm' (modulo).
libflow had the block size hardcoded. The currents users of libflow, namely f3write and f3read, now pass the block size of the file system. While this might improve the performance of libflow, the motivation for this change is to prepare libflow to integrate with f3brew.
libflow last dependency is the macro SECTOR_SIZE. Since all F3 tools includes library libutils, this commit moves SECTOR_SIZE to libutils. From now on, library utils should focus on centralizing file-system-related functions since only f3write and f3read employ this library.
This commit adds the parameters --max-read-rate, --max-write-rate, and --show-progress that work analogously to the same parameters in f3write and f3read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
In addition to the new features above, this pull request includes code improvements, such as deduplicating code, fixing header inclusions, and removing header dependencies.
This pull request supersedes pull request #236.