Merged
Conversation
JamalAlabdullah
added
backport-ignore
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughRemoved a previously present Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/features/pdf/PDFView.module.css (1)
37-41: LGTM — the@media printoverride correctly unblocks clipped content in generated PDFs.The placement inside
@media print(rather than scopingoverflow: hiddento@media screen) is the right call given the Cypress caveat documented in lines 2–5: keeping the base rule unscoped ensures Cypress still exercises the hidden-overflow state.As an optional alternative, if the Cypress limitation is ever resolved, the two rules could be collapsed into a single
@media screendeclaration:♻️ Optional future refactor (only if Cypress gains `@media` print support)
.pdf-wrapper { /* Hide interactive elements from PDF * This makes testing easier as cypress does not support rendering in `@media` print mode * `@see` https://github.com/cypress-io/cypress/issues/790 */ & button, & [role='button'] { display: none !important; } - overflow: hidden; } +@media screen { + .pdf-wrapper { + overflow: hidden; + } +} + `@media` print { - .pdf-wrapper { - overflow: visible; - } - .hideInPrint {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/pdf/PDFView.module.css` around lines 37 - 41, The `@media` print rule for .pdf-wrapper is correct and requires no change—keep the overflow: visible override inside the `@media` print block (refer to .pdf-wrapper and `@media` print in PDFView.module.css); only consider collapsing into a single `@media` screen rule in the future if Cypress gains `@media` print support, otherwise leave as-is.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/features/pdf/PDFView.module.css`:
- Around line 37-41: The `@media` print rule for .pdf-wrapper is correct and
requires no change—keep the overflow: visible override inside the `@media` print
block (refer to .pdf-wrapper and `@media` print in PDFView.module.css); only
consider collapsing into a single `@media` screen rule in the future if Cypress
gains `@media` print support, otherwise leave as-is.
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Magnusrm
approved these changes
Feb 18, 2026
bjosttveit
reviewed
Feb 18, 2026
JamalAlabdullah
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
NOTE:
The un-passed test is not related to the changes that made in this PR, I will check
Missing data is fixed , but i noticed that there is error in order in som places not in all. I am not sure if this is an error and we need to create PR for it?
closes #17674
After:
Screen.Recording.2026-02-18.at.15.54.31.mov
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit