Merged
Conversation
xieandrew
reviewed
Jan 15, 2026
Collaborator
xieandrew
left a comment
xieandrew
left a comment
There was a problem hiding this comment.
Looks good, just one question
| spark.eventLog.dir /home/iceberg/spark-events | ||
| spark.history.fs.logDirectory /home/iceberg/spark-events | ||
| spark.sql.catalogImplementation in-memory | ||
| # spark.sql.session.timeZone America/Chicago |
Collaborator
There was a problem hiding this comment.
Why is the example added here instead of under services.spark-iceberg.configs, which is where the README says to add it? I know both will work but wondering for consistency if they should be in the same place.
Collaborator
Author
There was a problem hiding this comment.
updated README, please check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docker compose to set clickhouse server/spark session timezone.