[O2B-1520] Add filtering by run intervals to envs #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated multiple granular filtering tests into one comprehensive test that applies all filters in sequence. This streamlines the test suite.
Updated GetAllEnvironmentsDto and GetAllEnvironmentsUseCase to support runNumbers filtering using ranges. Added range to large filter test case.
Refactored range validation logic to use a custom error code (RANGE_INVALID) and improved error messages for invalid input formats in DTOs. Enhanced rangeUtils to handle empty values, multiple dashes, and non-numeric input more robustly. Updated related tests and API validation to reflect new error handling and messaging.
isaachilly
added
frontend
backend
javascript
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2062 +/- ##
==========================================
+ Coverage 45.68% 45.69% +0.01%
==========================================
Files 1031 1031
Lines 17206 17208 +2
Branches 3134 3131 -3
==========================================
+ Hits 7861 7864 +3
+ Misses 9345 9344 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed strict rejection of empty entries in run number filters, allowing filters like '103,,' to be processed. Added comprehensive tests for valid and invalid run number ranges, including edge cases with empty entries and invalid formats, to ensure correct API and use case behaviour.
Updated validateRange to skip non-numeric inputs instead of returning an error.
Update validateRange to return an error on invalid numbers instead of continuing. Adjust test to remove non-numeric run number from input, reflecting stricter validation.
isaachilly
changed the title
Simplified the range validation logic in rangeUtils.js by removing redundant checks and revert to using parseInt for number parsing. Revert test too.
Previous rangeUtils would not allow negative number due to parseInt converting "" from the split to NaN but with Number this gets converted to 0 making a valid range. Removing tests for dashes, this is a good test however was deemed things could be relying on the api allowing input such as 1-2-3 even if incorrect.
graduta
requested changes
Jan 27, 2026
graduta
approved these changes
Jan 27, 2026
isaachilly
deleted the
improv/O2B-1520/Add-filtering-by-run-intervals-to-envs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: