[O2B-1506] LHCfills run duration filter #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Houwie7000
added
frontend
backend
javascript
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2038 +/- ##
==========================================
+ Coverage 45.58% 45.67% +0.09%
==========================================
Files 1031 1031
Lines 17172 17206 +34
Branches 3123 3134 +11
==========================================
+ Hits 7827 7859 +32
- Misses 9345 9347 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Houwie7000
force-pushed
the
feature/O2B-1505/lhcfills-beam-duration-filter
branch
from
23dbb7b to
11c1f9d
Compare
Houwie7000
force-pushed
the
feature/O2B-1506/lhcfills-run-duration-filter
branch
2 times, most recently
from
fd1be9f to
2c6fee8
Compare
This reverts commit 695622b.
…ith the query/reset logic. Just set the value afterwards
Houwie7000
force-pushed
the
feature/O2B-1505/lhcfills-beam-duration-filter
branch
from
5c9fecd to
950022d
Compare
…ature/O2B-1506/lhcfills-run-duration-filter update from upstream
…ature/O2B-1506/lhcfills-run-duration-filter update from upstream
…ature/O2B-1506/lhcfills-run-duration-filter update from upstream
Base automatically changed from
feature/O2B-1505/lhcfills-beam-duration-filter
to
main
January 21, 2026 14:41
…fills DTO. QueryBuilder WhereAssociationQueryBuilder has been changed to handle associations with an OR operator. Added tests
isaachilly
reviewed
Jan 22, 2026
lib/public/components/Filters/LhcFillsFilter/runDurationFilter.js
Outdated
Show resolved
Hide resolved
isaachilly
reviewed
Jan 22, 2026
isaachilly
reviewed
Jan 23, 2026
Collaborator
isaachilly
left a comment
isaachilly
left a comment
There was a problem hiding this comment.
Looks good but will add my changes next commit
Introduced greaterThanOrNull and lowerThanOrNull methods in QueryBuilder to handle cases where 0 is stored as null in the database. Used these methods instead of editing _or and applyOperation methods. Added tests to check <= and >= in the usecase work correctly.
isaachilly
previously approved these changes
Jan 25, 2026
graduta
requested changes
Jan 27, 2026
Fix 'statistics' association so it performs as intended; only being included in the query if associatedStatisticsRequired is true.
Corrected the logic in QueryBuilder's greaterThanOrNull and lowerThanOrNull methods when the notFlag is set.
Added unit tests for QueryBuilder's greaterThanOrNull and lowerThanOrNull methods using RunRepository. Tests cover inclusive and exclusive comparisons, as well as negated conditions.
graduta
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database:
-None.