Heather, Danielle, Yasmin, and Mary's Zoolily#32
Open
heatherherrington wants to merge 367 commits intoAda-C6:masterfrom
Open
Heather, Danielle, Yasmin, and Mary's Zoolily#32heatherherrington wants to merge 367 commits intoAda-C6:masterfrom
heatherherrington wants to merge 367 commits intoAda-C6:masterfrom
Conversation
Merging review controller & tests
added migration for url column in products
…fixed some indentation
Author
|
Test coverage (not all passing, alas) up to 81%, fixed case-sensitive search functionality on heroku deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team Look at All the Fox We Give!
Heroku link: https://zoolily.herokuapp.com/
Things to improve:
Testing coverage. Right now, we're only at 75% and some of our tests are failing. However, the website itself appears functional. Also, while some of the Sessions Controller tests are "green" in simplecov, the tests themselves are all failing and none of us could figure out why.
Our Merchant dashboard is pretty bare-bones right now. It ended up getting blocked by cart functionality and we didn't have time to fix it.
Our search function is still case-sensitive. Heather intends to try to fix this over the weekend. Maybe.
Our "make a new category" works but doesn't redirect to the "correct" page.
Things that are awesome:
The images on our home page generate randomly and do not repeat.
Validations for placing a new order.
You can retire and reinstate a product, which changes where they are displayed on index and show pages.
Our awesome monkey icon review things :)
We used a favicon of a pig in boots.
Drop down menus on header, order page, review page - it limits what possible errors the user could introduce.
All of our logged-in vs logged-out functionality is working (we think), including merchants not being able to review their own products and only logged in merchants being able to edit their products. For the most part, if someone isn't allowed to do something, that button or link simply doesn't appear and the direct URI will redirect.