Open
Conversation
…h a negative balance.
…n generating it itself.
…the keys and the account objects as the values
|
just trying some things out - plz ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully completed base requirements and optionals for Wave 1 and 2.
See the added
savings_testandchecking_testfiles for some of the testing that I did. I wanted to make sure that creating new accounts of both types worked and that each of the methods for each class worked. Additionally, I tested in irb the ability to create a new checking account andwithdraw_using_checkand utilize theOVERDRAFTvariable, and then try to do a normalwithdrawrequest and have it not work, sincewithdrawuses the normalMIN_BALANCEof the class.When implementing the
withdraw_using_checkmethod, I had a little bit of trouble figuring out how to skip the normalwithdrawmethod in the checking account, since I wanted to pass a different min balance, but found that I can use an alias to call the parent class's version of the method and pass in myOVERDRAFTinstead.