Open
Conversation
CheezItMan
reviewed
Nov 4, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You didn't quite finish them all and you didn't manage to do reverse in place. However the other methods are pretty well done although several lack space/time complexity. Take a look at my comments and let me know what questions you have.
Comment on lines
+3
to
5
| # Time complexity: O(n) ['n' being the number of times factorial computation has to be implemented until n reaches 0] | ||
| # Space complexity: 0(n) ['n' being the number of function calls on the stack] | ||
| def factorial(n) |
Comment on lines
+12
to
+14
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def reverse(s, i = 1) |
lib/recursive-methods.rb
Outdated
Comment on lines
21
to
23
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def reverse_inplace(s) |
There was a problem hiding this comment.
Suggested change
| # Time complexity: ? | |
| # Space complexity: ? | |
| def reverse_inplace(s) | |
| # Time complexity: ? | |
| # Space complexity: ? | |
| def reverse_inplace(s, low = 0, high = s.length - 1) |
Comment on lines
+29
to
31
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n) |
lib/recursive-methods.rb
Outdated
Comment on lines
36
to
38
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def nested(s) |
Comment on lines
47
to
+49
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def search(array, value) | ||
| raise NotImplementedError, "Method not implemented" | ||
| def search(array, value, i = 0) |
lib/recursive-methods.rb
Outdated
| def digit_match(n, m) | ||
| raise NotImplementedError, "Method not implemented" | ||
| end No newline at end of file | ||
| puts "Sorry, I couldn't figure this one out!" |
There was a problem hiding this comment.
Understood, does this help?
Suggested change
| puts "Sorry, I couldn't figure this one out!" | |
| if n == 0 || m == 0 | |
| return n % 10 == m % 10 ? 1 : 0 | |
| end | |
| new_n = n / 10 | |
| new_m = m / 10 | |
| if n % 10 == m % 10 | |
| # your code |
CheezItMan
reviewed
Nov 11, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Kayla, thanks for getting this in. This is outstanding work. Take a look at my comments and let me know what questions you have.
Comment on lines
+21
to
+23
| # Time complexity: O(n) -still has to iterate over every element in string | ||
| # Space complexity: O(n) -stack can get very large if string is big | ||
| def reverse_inplace_helper(s, start, finish) |
Comment on lines
+73
to
+75
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def digit_helper(n, m, match = 0, place = 0) |
Comment on lines
+56
to
+58
| # Time complexity: O(n) best case O(1) if item is in index 1? | ||
| # Space complexity: O(n) best case O(1) if item is in index 1? | ||
| def search(array, value, i = 0) |
Comment on lines
+45
to
47
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def nested(s) |
There was a problem hiding this comment.
Due to the slice you're doing, this is O(n^2) for both time/space.
Otherwise 👍
Comment on lines
+65
to
67
| # Time complexity: O(n) - traversing the whole string | ||
| # Space complexity: O(n) -traversing the whole string | ||
| def is_palindrome(s) |
There was a problem hiding this comment.
Due to the slice this is O(n^2), but otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.