Open
Conversation
CheezItMan
reviewed
Nov 4, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done Lina, take a look at my comments especially regarding the reverse_inplace method. Let me know what questions you have via Slack.
Comment on lines
+3
to
5
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
Comment on lines
+16
to
18
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def reverse(s) |
lib/recursive-methods.rb
Outdated
Comment on lines
28
to
30
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def reverse_inplace(s) |
There was a problem hiding this comment.
Think about adjusting the method signature to this.
def reverse_inplace(s, low = 0, high = s.length - 1)Does this help you see a way to do it in-place.
Comment on lines
+38
to
40
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n) |
lib/recursive-methods.rb
Outdated
Comment on lines
48
to
50
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def nested(s) |
There was a problem hiding this comment.
👍 , however can you see a way to do this O(n) in time/space?
lib/recursive-methods.rb
Outdated
Comment on lines
60
to
62
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def search(array, value) |
lib/recursive-methods.rb
Outdated
Comment on lines
72
to
74
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def is_palindrome(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.