Merged
Conversation
Contributor
|
Thanks! The changes look good to me. |
Contributor
Author
|
there's a couple of versions in play with ESP-IDF, 5.3 or 5.4 are commonly used for Rust, 5.5 is the latest stable release, and 6.0 is currently in pre-release mode. Do you want me to setup with 5.5 and 6.0? |
Contributor
|
Latest stable sounds good to me! |
ESP-IDF 6.0 has a higher warning level, and has phased out `esp_netif_next()`. `esp_netif_next_unsafe()` is basically the same, but the rename is to alert people to its inherent unsafe nature. Using `esp_netif_tcpip_exec()` ensures the proper safety and avoids use after free situations. The redundant move and missing field initializer were causing build failures.
Contributor
Author
|
Humbly requesting a new release (b2?) with once this is in |
Contributor
Author
|
Looks like v5.5 built nicely. You sure you don't want matrix with 5.3, 5.5 and 6.0, just like Linux and Windows have multiple? |
Contributor
|
For now I think one version is enough. Adding another matrix will lead to CI runs taking even longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP-IDF 6.0 has a higher warning level, and has phased out
esp_netif_next().esp_netif_next_unsafe()is basically the same, but the rename is to alert people to its inherent unsafe nature. Usingesp_netif_tcpip_exec()ensures the proper safety and avoids use after free situations.The redundant move and missing field initializer were causing build failures.