Skip to content

Use int64_t consistently for time #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgo-ableton merged 1 commit into from
Dec 15, 2025
Merged

Use int64_t consistently for time #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extensions/abl_link/include/abl_link.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,19 +317,19 @@ extern "C"
* join.
*/
void abl_link_force_beat_at_time(
abl_link_session_state session_state, double beat, uint64_t time, double quantum);
abl_link_session_state session_state, double beat, int64_t time, double quantum);

/*! @brief: Set if transport should be playing or stopped, taking effect at the given
* time.
*/
void abl_link_set_is_playing(
abl_link_session_state session_state, bool is_playing, uint64_t time);
abl_link_session_state session_state, bool is_playing, int64_t time);

/*! @brief: Is transport playing? */
bool abl_link_is_playing(abl_link_session_state session_state);

/*! @brief: Get the time at which a transport start/stop occurs */
uint64_t abl_link_time_for_is_playing(abl_link_session_state session_state);
int64_t abl_link_time_for_is_playing(abl_link_session_state session_state);

/*! @brief: Convenience function to attempt to map the given beat to the time
* when transport is starting to play in context of the given quantum.
Expand All @@ -343,7 +343,7 @@ extern "C"
void abl_link_set_is_playing_and_request_beat_at_time(
abl_link_session_state session_state,
bool is_playing,
uint64_t time,
int64_t time,
double beat,
double quantum);

Expand Down
10 changes: 5 additions & 5 deletions extensions/abl_link/src/abl_link.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,14 @@ extern "C"
}

void abl_link_force_beat_at_time(
abl_link_session_state session_state, double beat, uint64_t time, double quantum)
abl_link_session_state session_state, double beat, int64_t time, double quantum)
{
reinterpret_cast<ableton::Link::SessionState *>(session_state.impl)
->forceBeatAtTime(beat, std::chrono::microseconds{time}, quantum);
}

void abl_link_set_is_playing(
abl_link_session_state session_state, bool is_playing, uint64_t time)
abl_link_session_state session_state, bool is_playing, int64_t time)
{
reinterpret_cast<ableton::Link::SessionState *>(session_state.impl)
->setIsPlaying(is_playing, std::chrono::microseconds(time));
Expand All @@ -185,9 +185,9 @@ extern "C"
->isPlaying();
}

uint64_t abl_link_time_for_is_playing(abl_link_session_state session_state)
int64_t abl_link_time_for_is_playing(abl_link_session_state session_state)
{
return static_cast<uint64_t>(
return static_cast<int64_t>(
reinterpret_cast<ableton::Link::SessionState *>(session_state.impl)
->timeForIsPlaying()
.count());
Expand All @@ -203,7 +203,7 @@ extern "C"
void abl_link_set_is_playing_and_request_beat_at_time(
abl_link_session_state session_state,
bool is_playing,
uint64_t time,
int64_t time,
double beat,
double quantum)
{
Expand Down