Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes support for Scala 2.12.x from the project, narrowing the supported versions to Scala 2.13+ and Scala 3.x.
Changes:
- Removed Scala 2.12.15 from the CI build matrix
- Deleted the Scala 2.13- compatibility layer file
- Added MiMa filters for breaking changes related to dropping 2.12 support
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build.yml | Removed Scala 2.12.15 from the build matrix |
| monix-execution/shared/src/main/scala_2.13-/monix/execution/compat.scala | Deleted entire compatibility layer for Scala versions before 2.13 |
| project/MimaFilters.scala | Added binary compatibility filters for version-specific changes |
| build.sbt | Registered the new MiMa filters in the build configuration |
Comments suppressed due to low confidence (1)
project/MimaFilters.scala:104
- The name 'changesFor_avs' is ambiguous and inconsistent with the existing naming pattern (e.g., 'changesFor_3_0_1', 'changesFor_3_2_0'). Consider using a more descriptive name that follows the established convention, such as 'changesFor_4_0_0' or 'changesFor_scala2_12_removal' to clearly indicate what version or change this relates to.
lazy val changesFor_avs = Seq(
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.