Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes support for Java 7 by eliminating platform intrinsics parameters and Java 7-specific atomic implementations. The changes update method signatures across atomic builders and implementations to no longer accept the allowPlatformIntrinsics parameter, which was previously used to distinguish between Java 7 and Java 8+ optimizations.
Changes:
- Removed
allowPlatformIntrinsicsparameter from atomic builder methods and related factory functions - Deleted Java 7-specific atomic implementation classes (e.g.,
NormalJava7BoxedInt,Left64Java7BoxedLong) - Updated test suites to remove
allowPlatformIntrinsicsparameters from test instantiations - Added MIMA filters to document binary compatibility changes related to dropping JDK 7 support
Reviewed changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| project/MimaFilters.scala | Adds binary compatibility filters for internal API changes from dropping JDK 7 |
| monix-execution/shared/src/test/scala/monix/execution/atomic/AtomicNumberSuite.scala | Removes allowPlatformIntrinsics parameter from test suite signatures |
| monix-execution/jvm/src/test/scala/monix/execution/atomic/ConcurrentAtomicSuite.scala | Updates concurrent test suites to remove Java 7 compatibility parameters |
| monix-execution/jvm/src/test/scala/monix/execution/atomic/ConcurrentAtomicNumberSuite.scala | Removes platform intrinsics parameters from concurrent number tests |
| monix-execution/jvm/src/main/scala_3.0/monix/execution/atomic/Atomic.scala | Updates Scala 3 atomic factory methods to use new signature |
| monix-execution/jvm/src/main/scala_3.0-/monix/execution/atomic/Atomic.scala | Updates Scala 2 macro implementations for atomic creation |
| monix-execution/jvm/src/main/scala/monix/execution/internal/collection/queues/*.scala | Simplifies queue builder logic by removing Java 7 compatibility checks |
| monix-execution/jvm/src/main/scala/monix/execution/atomic/*.scala | Updates atomic type implementations with deprecated overloads for backward compatibility |
| monix-execution/jvm/src/main/scala/monix/execution/atomic/AtomicBuilder.scala | Adds deprecated overloads and updates builder implementations |
| monix-execution/jvm/src/main/java/monix/execution/internal/atomic/Java7.java | Deletes Java 7-specific atomic implementations |
| monix-execution/jvm/src/main/java/monix/execution/internal/atomic/Factory.java | Simplifies factory methods to only support Java 8+ intrinsics |
| monix-execution/js/src/main/scala_3.0/monix/execution/atomic/Atomic.scala | Updates JavaScript platform atomic creation for consistency |
| monix-execution/js/src/main/scala_3.0-/monix/execution/atomic/Atomic.scala | Updates JavaScript platform macros |
| monix-execution/js/src/main/scala/monix/execution/atomic/AtomicBuilder.scala | Updates JavaScript atomic builders with deprecated overloads |
| build.sbt | Adds MIMA filter configuration for the new version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.