Bump SBT 1.10.7, Scala 2.12.20/2.13.16/3.3.5, and all build plugins#5
Open
halotukozak wants to merge 27 commits intoseries/3.x-avsfrom
Open
Bump SBT 1.10.7, Scala 2.12.20/2.13.16/3.3.5, and all build plugins#5halotukozak wants to merge 27 commits intoseries/3.x-avsfrom
halotukozak wants to merge 27 commits intoseries/3.x-avsfrom
Conversation
- Bump kind-projector and silencer versions\n - Silence other-implicit-type warnings in 2.13\n - Revert sbt-assembly to 1.2.0 to keep shading working
- Explicitly state that starting a new stack trace is intentional for performance and thread-safety\n - Add verification tests in TracingSuite
….typelevel 0.5.3 - Replace io.github.davidgregory084 group with org.typelevel in project/plugins.sbt - Update plugin version from 0.3.1 to 0.5.3 - Add explicit import org.typelevel.scalacoptions.ScalacOptions to build.sbt (required by 0.5.x API) - SBT loads without errors after migration
…tion plan - Create 01-01-SUMMARY.md documenting the org.typelevel migration - Update STATE.md with current position (Phase 01, Plan 02 next) and decisions - Update ROADMAP.md plan progress (1/2 summaries for phase 01) - Mark requirement UP-02 complete in REQUIREMENTS.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add -Wconf:msg=unused value of type:silent for Scala 2.13 to suppress -Wvalue-discard warnings newly enabled by tpolecat 0.5.x (pre-existing patterns like trySuccess/tryFailure returning Boolean are intentional) - Remove -Werror for Scala 3 (tpolecat 0.5.x uses -Werror, not -Xfatal-warnings; the existing removal of -Xfatal-warnings was insufficient) - Fix CancelablePromise.scala:245: add @unchecked to val x :: xs pattern (Scala 3 requires annotation for refutable patterns used as definitions) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erns
Add Test / scalacOptions --= to remove warnings that tpolecat 0.5.x newly
enables for test compilation but which trigger on pre-existing test patterns:
- Remove -Wunused:patvars (2.13) / -Ywarn-unused:patvars (2.12): triggers on
for-comprehension loop vars (e.g. `for (i <- 0 until 5) yield Future {...}`)
- Remove -Xlint:constant (2.13): triggers on intentional overflow tests
(e.g. `mc.orderedUpdate(c2, Long.MaxValue + 1)` in OrderedCancelableSuite)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Create 01-02-SUMMARY.md documenting UAT-verified cross-compilation success on Scala 2.12.20, 2.13.16, and 3.3.5 - Update STATE.md: Phase 01 all plans complete; document known issues (CatsEffectIssue380Suite JS hang, MiMa TrampolineExecutionContext) - Update ROADMAP.md: Phase 1 marked complete (2/2 plans done) - Mark requirements UP-01 and UP-02 complete in REQUIREMENTS.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates Monix’s build toolchain to newer SBT/Scala patch versions and refreshes sbt plugins, with follow-up compilation/test adjustments to accommodate tpolecat 0.5.x warning defaults and Scala 3 compiler strictness.
Changes:
- Bumped SBT to 1.10.7, updated Scala versions in CI, and upgraded build plugins (including tpolecat → 0.5.3 under org.typelevel).
- Adjusted
scalacOptions/-Wconfsuppressions and test-scope compiler options to keep cross-compilation working under the new toolchain. - Applied a Scala 3 refutable-pattern fix (
@unchecked) and added/updated tracing tests and documentation notes about fiber stack-trace behavior.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
project/build.properties |
Bumps SBT version to 1.10.7. |
project/plugins.sbt |
Updates sbt plugin versions and adds a dependency scheme override for geny. |
build.sbt |
Adds tpolecat-related -Wconf suppressions, tunes test-scope scalac options, and disables Scala 3 fatal warnings. |
.github/workflows/build.yml |
Updates Scala versions in the CI matrix. |
.jvmopts |
Removes a legacy JVM option. |
monix-execution/shared/src/main/scala/monix/execution/CancelablePromise.scala |
Scala 3 compatibility tweak for a refutable pattern binding. |
monix-eval/shared/src/main/scala/monix/eval/Task.scala |
Documents stack-trace behavior for Task.start / startAndForget. |
tracingTests/src/test/scala/tracing/TracingSuite.scala |
Adds tests asserting stack-trace isolation behavior for fibers. |
.planning/** |
Adds planning/roadmap/state docs for the maintenance effort and decisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compilation fixes
-Wconfsuppressions for tpolecat 0.5.x value-discard warnings (Scala 2.13)-Werrorfor Scala 3 (tpolecat 0.5.x API change)CancelablePromise.scalarefutable pattern for Scala 3 (@unchecked)other-implicit-typewarning for Scala 2.13.16Known issues (pre-existing, not introduced by this PR)
CatsEffectIssue380Suitehangs — unrelated to dependency changesTrampolineExecutionContextstartLoopsignature change — intentional fix from earlier commit onseries/3.x-avs, needs exclusion filterTest plan
sbt exitloads without errorssbt ++2.12.20 compilepassessbt ++2.13.16 compilepassessbt ++3.3.5 compilepassessbt +test(JVM tests pass; JS hangs on pre-existing issue)sbt +mimaReportBinaryIssues(needs TrampolineEC exclusion filter)🤖 Generated with Claude Code