Conversation
🎉 Deploy Previewhttps://lettering-dk7qzs6k5-yyypearls-projects.vercel.app |
yyypearl
approved these changes
May 4, 2025
Contributor
|
네 env도 반영했습니다~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
연관 이슈
close #163
개요
구글 로그인 구현
✅ 작업 내용
🖥 구현 결과
2025-05-04.1.18.41.mov
2025-05-04.1.19.06.mov
리뷰 요구사항
📝 기타 사항
/login/auth부분이 좀 수정이 되었어요!!switch 문으로 각 type에 따라 다른 try catch 문을 실행하도록 했는데, 가독성 측면에서는 좋을 것 같아 이런 방식으로 구현했어요
const [oauthAccessToken, setOauthAccessToken] = useState('');
발급받은 oauth 토큰을 state로 저장해 백엔드 서버에 전송하는 방식입니다
(oauthtoken이 없다면 서버로 전송되지 않습니다)
저번에 리뷰해줬던 부분도 새롭게 반영했어요~~~
현재 네이버 로그인이 합쳐지진 않은 상태기 때문에 준비중도 급하게 추가했어요
바로 서버에 반영되는 걸 미처 생각하고 있지 못했네요...
env는 노션에 적어둘게용