Open
Conversation
… app is set to deafult system them and I have added a toggle button in the home screen on pressing which the theme of the app changes.
Contributor
|
Hi @khushi-hura , Good efforts on the feature implementation! However, this is a big task, and it will require more time to polish. Here are a few points that need improvement:
Also you are not following the contribution guidelines as this PR is merging the commit to main branch |
Contributor
Author
|
hey @bhavik-mangla gsoc-2025 is the branch in my fork repository, in which branches should I request for the commits to be merged in upstream repository while raising PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried to manage recording audios and sending them to peers.
There are three icon buttons working on this:
audioDemo.mp4
Looking forward to working on this issue more deeply after getting reviewed!