Add constructor for UnicodeIdentificationMetadata#3746
Open
mjkoo wants to merge 1 commit intoAFLplusplus:mainfrom
Open
Add constructor for UnicodeIdentificationMetadata#3746mjkoo wants to merge 1 commit intoAFLplusplus:mainfrom
mjkoo wants to merge 1 commit intoAFLplusplus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The four provided Unicode mutators are public, but are effectively unusable outside of the libafl crate due to
extract_metadatabeingpub(crate)andUnicodeIdentificationMetadatanot having a public constructor. This makes it convoluted/impossible (outside of a deserialize hack) to construct a non-emptyUnicodeIdentificationMetadatawhich short-circuits the mutations.This PR adds
UnicodeIdentificationMetadata::newas a constructor wrapping theextract_metadatafunctionality (moved to a privateextract_rangeshelper), and updates internal callers to use the public constructor.Checklist
./scripts/precommit.shand addressed all comments