render should only call next after the rendering engine is done#646
Open
jfremy wants to merge 1 commit into1602:masterfrom
Open
render should only call next after the rendering engine is done#646jfremy wants to merge 1 commit into1602:masterfrom
jfremy wants to merge 1 commit into1602:masterfrom
Conversation
…the page & template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ejs 2.x, compound stops working.
The reason is that the current code assumes the render engine is synchronous and calls next after making its last render call. This is not a valid expectation (ejs does not follow this).
With this change, next is only called after the full rendering is done.
Fix compoundjs with ejs 2.x (1.x still works)