feat: postgres vector store#231
Conversation
|
@0xMochan @cvauclair do you mind taking a look into this? |
13857d9 to
a3caabb
Compare
|
Hey @carlos-verdes just saw your ping, wasn't sure if the PR was ready for review since it's still a draft but I'll take a look later today! Thanks a lot for the PR, let's get this |
|
It's in draft because documentation is not finished, but the code + example + integration test is ready. I can add later an example using Streams if that would be useful! |
cvauclair
left a comment
There was a problem hiding this comment.
Looks solid! I added a couple suggestions/comments, please take a look when you have a moment.
Cheers!
|
@cvauclair thanks for the review, I updated code based on your comments, take a look and let me know if you want to squash the commits. |
ff87b41 to
0450fe4
Compare
0450fe4 to
ca8c3aa
Compare
cvauclair
left a comment
There was a problem hiding this comment.
Awesome work, thanks for the contribution @carlos-verdes !
|
Thanks for the kind words, I just realized that main README is not updated :) |
Resolves #5 based on PR #157
@milancermak mentioned not having time to finish his PR so I created this one based on his implementation.
Current code has just the library code but I added an integration test based on rig-qdrant module, it starts a Docker container with Postgres + PgVector and it simulate calls to OpenAI using a mocked API.
Difference from previous PR:
Serializable,Deserializablemake run(from rig-postgres folder), load environmental variables from.envfile and handles documents with more than one embedding. It also runs migrations automatically on the database to make sure Postgres tables are ready for the test.Pending: