feat(anthropic): add Claude 4.6 adaptive thinking support#1480
Open
illegalcall wants to merge 3 commits into0xPlaygrounds:mainfrom
Open
feat(anthropic): add Claude 4.6 adaptive thinking support#1480illegalcall wants to merge 3 commits into0xPlaygrounds:mainfrom
illegalcall wants to merge 3 commits into0xPlaygrounds:mainfrom
Conversation
rig/rig-core/CHANGELOG.md
Outdated
Comment on lines
+10
to
+18
| ### Added | ||
|
|
||
| - support Anthropic adaptive thinking for Claude 4.6 (`thinking.type = "adaptive"` with `output_config.effort`) with typed request mapping for both streaming and non-streaming paths | ||
| - add new Claude 4.6 model constants: `claude-opus-4-6`, `claude-sonnet-4-6` | ||
|
|
||
| ### Fixed | ||
|
|
||
| - preserve legacy Anthropic manual thinking support (`thinking.type = "enabled"` and `budget_tokens`) in both streaming and non-streaming request conversion | ||
| - add model-aware validation for adaptive thinking / `output_config.effort: "max"` on known unsupported Anthropic models (both streaming and non-streaming) while preserving pass-through for unknown future model variants |
Collaborator
There was a problem hiding this comment.
ah crap, just realised we need to delete this part
Contributor
Author
There was a problem hiding this comment.
Cool Thanks, anything I need to do?
Collaborator
There was a problem hiding this comment.
Nah it's fine I added a commit to fix it. Should be fine now. I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1452
Summary
Adds Anthropic Claude 4.6 adaptive thinking support in
rig-core, including typed handling forthinkingandoutput_configin both streaming and non-streaming requests.This also preserves legacy manual thinking support and adds validation for known unsupported models.
Testing
cargo test -p rig-core test_adaptive_thinking -- --nocapture