Merge the driver of NS16650 and NS16550A to reduce code duplication#352
Merged
han-jiang277 merged 2 commits intovivoblueos:mainfrom Mar 8, 2026
Merged
Conversation
Merge the driver of NS16650 and NS16550
Now the name of driver code is ns16x50.rs
x means it can be 5, 6, 7 or other digits
Contributor
Author
|
build_prs #352 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22759266700. |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22759266700. |
Contributor
Author
|
build_prs #352 |
|
❌ Job failed. Failed jobs: setup (failure). Skipped jobs: check_format (skipped), check_license (skipped), build_host (skipped), build_and_check_boards (skipped), see https://github.com/vivoblueos/kernel/actions/runs/22759814305. |
Contributor
Author
|
build_prs #352 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22759966660. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22759966660. |
Contributor
|
LGTM |
han-jiang277
changed the title
han-jiang277
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the driver of NS16650 and NS16550 to reduce code duplication
Now the name of driver code is ns16x50.rs
x means it can be 5, 6, 7 or other digits