Add UART printing on qemu_riscv64 by YinhuaChen-cloud · Pull Request #343 · vivoblueos/kernel

YinhuaChen-cloud · 2026-03-05T03:23:22Z

Add UART printing on qemu_riscv64

Fixes #339

CLAassistant · 2026-03-05T03:23:28Z

All committers have signed the CLA.

YinhuaChen-cloud · 2026-03-05T03:24:11Z

build_prs #343

github-actions · 2026-03-05T03:25:23Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22700766319.

lawkai-vivo · 2026-03-05T03:26:45Z

driver/src/uart/mod.rs

 #[cfg(target_chip = "gd32vw55x")]
 pub mod gd32vw55x;
 pub mod ns16650;
+pub mod ns16550a;


What's the difference between ns16550a and ns16550?

see wiki: (https://en.wikipedia.org/wiki/16550_UART). The "Issue with the buffer" section.
"""
The original 16550 had a bug that prevented this FIFO from being used. National Semiconductor later released the 16550A which corrected this issue.
"""

lawkai-vivo · 2026-03-05T03:26:53Z

driver/src/uart/ns16550a.rs

@@ -0,0 +1,154 @@
+// Copyright (c) 2025 vivo Mobile Communication Co., Ltd.


Suggested change

// Copyright (c) 2025 vivo Mobile Communication Co., Ltd.

// Copyright (c) 2026 vivo Mobile Communication Co., Ltd.

lawkai-vivo · 2026-03-05T03:27:41Z

kernel/src/boards/qemu_riscv64/config.rs

@@ -17,5 +17,5 @@
 use crate::arch::irq::IrqNumber;


Does this driver work on qemu_riscv32?

not yet, but I can make it work

qemu_riscv32 is supported

github-actions · 2026-03-05T03:29:58Z

❌ Job failed. Failed jobs: check_format (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22700766319.

xuchang-vivo · 2026-03-05T03:44:02Z

driver/src/uart/mod.rs

 #[cfg(target_chip = "gd32vw55x")]
 pub mod gd32vw55x;
 pub mod ns16650;
+pub mod ns16550a;


Please check whether the ns16550 driver can be reused between the two platforms via modification.

I guess what you're asking is whether the ns16650 can be reused (ns16650 differs from ns16550 by just one digit).

The current only board which uses ns16650 is rk3568.

google "rk3568 TRM", see https://opensource.rock-chips.com/wiki_File:Rockchip_RK3568_TRM_Part1_V1.3-20220930P.PDF
At 25.4.2 Registers Summary, it says that each register of the rk3568 UART occupies a 4-byte MMIO space.
If rk3568 is using ns16650 UART, then it means that each register of ns16650 occupies a 4-byte MMIO space.

The manual of ns16550a is here: https://uart16550.readthedocs.io/en/latest/uart16550doc.html#registers
It says that most registers of ns16550a occupies a 1-byte MMIO space.

Therefore, the drivers for ns16550a and ns16650 are not compatible.

It looks like there’s no real difference in the operation logic; the only difference is that one is 4-byte and the other is 1-byte. Is it possible to reuse the same operation logic via conditional compilation?

change 2025 -> 2026 in driver/src/uart/ns16550a.rs add uart support for riscv32 rename NS16550A_UART0_IRQ as NS16550A_UART0_IRQNUM

YinhuaChen-cloud · 2026-03-05T07:53:19Z

build_prs #343

github-actions · 2026-03-05T07:54:50Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22707911821.

YinhuaChen-cloud · 2026-03-05T08:12:18Z

build_prs #343

github-actions · 2026-03-05T08:13:51Z

❌ Job failed. Failed jobs: check_format (failure), see https://github.com/vivoblueos/kernel/actions/runs/22707911821.

github-actions · 2026-03-05T08:15:04Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22708554673.

github-actions · 2026-03-05T08:20:06Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22708554673.

YinhuaChen-cloud · 2026-03-05T08:22:12Z

build_prs #343

github-actions · 2026-03-05T08:23:30Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22708903012.

github-actions · 2026-03-05T08:28:09Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22708903012.

YinhuaChen-cloud · 2026-03-05T08:34:11Z

build_prs #343

github-actions · 2026-03-05T08:35:28Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22709330284.

github-actions · 2026-03-05T08:45:08Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22709330284.

lawkai-vivo

LGTM. I don't have strong opinion of merging ns16550a and ns16550. Please wait for @xuchang-vivo 's feedback.

han-jiang277 · 2026-03-05T10:01:32Z

driver/src/uart/ns16550a.rs

+    }
+}
+
+impl HasInterruptReg for Ns16550a<'static> {


Add default impl in trait HasInterruptReg to reduce code duplication

add default impl for: - Has8bitDataReg - HasLineStatusReg - HasFifo - HasInterruptReg - PlatPeri

YinhuaChen-cloud · 2026-03-06T02:52:12Z

build_prs #343

github-actions · 2026-03-06T02:53:31Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22746863647.

github-actions · 2026-03-06T03:02:03Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22746863647.

Add UART printing on qemu_riscv64 (vivoblueos#339)

3ce2a01

lawkai-vivo reviewed Mar 5, 2026

View reviewed changes

xuchang-vivo reviewed Mar 5, 2026

View reviewed changes

lawkai-vivo changed the title ~~Add UART printing on qemu_riscv64 (#339)~~ Add UART printing on qemu_riscv64 Mar 5, 2026

format driver/src/uart/ns16550a.rs

0311a44

change 2025 -> 2026 in driver/src/uart/ns16550a.rs add uart support for riscv32 rename NS16550A_UART0_IRQ as NS16550A_UART0_IRQNUM

YinhuaChen-cloud requested review from lawkai-vivo and xuchang-vivo March 5, 2026 08:00

format driver/src/uart/mod.rs

59dfaaf

lawkai-vivo approved these changes Mar 5, 2026

View reviewed changes

lawkai-vivo mentioned this pull request Mar 5, 2026

Enable thread_metric on qemu_riscv32 #348

Open

han-jiang277 reviewed Mar 5, 2026

View reviewed changes

reduce code duplication

151e16d

add default impl for: - Has8bitDataReg - HasLineStatusReg - HasFifo - HasInterruptReg - PlatPeri

YinhuaChen-cloud requested a review from han-jiang277 March 6, 2026 03:02

han-jiang277 approved these changes Mar 6, 2026

View reviewed changes

han-jiang277 merged commit fdd5f27 into vivoblueos:main Mar 6, 2026
1 check passed

		@@ -0,0 +1,154 @@
		// Copyright (c) 2025 vivo Mobile Communication Co., Ltd.

	// Copyright (c) 2025 vivo Mobile Communication Co., Ltd.
	// Copyright (c) 2026 vivo Mobile Communication Co., Ltd.

Conversation

YinhuaChen-cloud commented Mar 5, 2026 • edited by lawkai-vivo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YinhuaChen-cloud commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YinhuaChen-cloud Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YinhuaChen-cloud commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

YinhuaChen-cloud commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

YinhuaChen-cloud commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

YinhuaChen-cloud commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

lawkai-vivo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YinhuaChen-cloud commented Mar 6, 2026

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

YinhuaChen-cloud commented Mar 5, 2026 •

edited by lawkai-vivo

Loading

CLAassistant commented Mar 5, 2026 •

edited

Loading

YinhuaChen-cloud Mar 5, 2026 •

edited

Loading