Skip to content

feat: add valid log output schemes for http and https #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SalmaElsoly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add valid log output schemes for http and https #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/gridtypes/zos/zlogs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ var (
"redis": {},
"ws": {},
"wss": {},
"http": {},
Copy link
Collaborator

@ashraffouda ashraffouda Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for supporting http and https?
I think http not the best protocol for sending logs wss or redis is much better/less overhead?

Copy link
Contributor Author

@SalmaElsoly SalmaElsoly Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was meant to support pushing to loki, there is no other way to push logs to Loki over WSS. Even if a service supports WSS, it would still forward logs to Loki over HTTP.

"https": {},
Copy link
Collaborator

@ashraffouda ashraffouda Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sending logs over http will put too much load let's check if u can do it with wss or redis

}
)

Expand Down
Loading