-
Notifications
You must be signed in to change notification settings - Fork 11
Description
As I was submitting my PR #31 I noticed that occasionally some of the edge tests would fail due to a mismatch in version expected. I saw you added this to the tests.
def get_latest_os(self, major: str, _os: str) -> set[str]:
url = f"https://msedgedriver.azureedge.net/LATEST_RELEASE_{major}_{_os.upper()}"
opts = set()
for i in range(15):
# This endpoint occasionally returns an older cached value,
# so we have to fish for the cache to make testing more robust and cut down on false errors.
latest_mac = self.fetch(url)
opts.add(latest_mac)
time.sleep(0.25)
return optsI'm curious if it was all of the endpoints on that domain or just the LATEST variations? I ask because that same endpoint is used in edge.get_url() which can result in users sometimes getting an error when it tries to download a version that doesn't actually exist.
Case in point https://github.com/bandophahita/pyderman/actions/runs/5084448185/jobs/9136756725 failed...
AssertionError: 'https://msedgedriver.azureedge.net/113.0.1774.57/edgedriver_mac64_m1.zip' != 'https://msedgedriver.azureedge.net/113.0.1774.50/edgedriver_mac64_m1.zip'
It would suggest that 113.0.1774.57 is incorrect as it does not appear in the xml found on https://msedgedriver.azureedge.net
However, the link works and the version of the driver matches the filename.
I susepct something more than web host caching is going on...