Skip to content

feat: improve sequencer metrics #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frisitano merged 11 commits into from
Jan 30, 2026
+37 −13
Merged

feat: improve sequencer metrics #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3e772db
Improve sequencer metrics
georgehao Dec 18, 2025
f8a42f4
fix comments
georgehao Jan 12, 2026
e7f150d
Merge branch 'main' into feat/improve_sequencer_metrics
georgehao Jan 12, 2026
83517bc
udpate
georgehao Jan 12, 2026
d941f8b
fix lint
georgehao Jan 12, 2026
d0a867c
fix
georgehao Jan 12, 2026
cb6a18c
fix conflict
georgehao Jan 13, 2026
0d607ef
fix comments
georgehao Jan 20, 2026
0bbc7b9
fix lint
georgehao Jan 20, 2026
75d432e
simplify block building recording
frisitano Jan 30, 2026
de0274d
Merge branch 'main' into feat/improve_sequencer_metrics
frisitano Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions crates/chain-orchestrator/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,13 +292,16 @@ impl<
}
}
SequencerEvent::PayloadReady(payload_id) => {
if let Some(block) = self
let block = self
.sequencer
.as_mut()
.expect("sequencer must be present")
.finalize_payload_building(payload_id, &mut self.engine)
.await?
{
.await?;

self.metric_handler.finish_block_building_recording(block.as_ref());

if let Some(block) = block {
let block_info: L2BlockInfoWithL1Messages = (&block).into();
self.database
.update_l1_messages_from_l2_blocks(vec![block_info.clone()])
Expand All @@ -307,7 +310,6 @@ impl<
.as_mut()
.expect("signer must be present")
.sign_block(block.clone())?;
self.metric_handler.finish_block_building_recording();
return Ok(Some(ChainOrchestratorEvent::BlockSequenced(block)));
}
}
Expand Down
40 changes: 31 additions & 9 deletions crates/chain-orchestrator/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use metrics::Histogram;
use metrics_derive::Metrics;
use reth_scroll_primitives::ScrollBlock;
use std::{collections::HashMap, time::Instant};
use strum::{EnumIter, IntoEnumIterator};

Expand All @@ -20,17 +21,33 @@ impl MetricsHandler {

/// Starts tracking a new block building task.
pub(crate) fn start_block_building_recording(&mut self) {
if self.block_building_meter.start.is_some() {
if self.block_building_meter.block_building_start.is_some() {
tracing::warn!(target: "scroll::chain_orchestrator", "block building recording is already ongoing, overwriting");
}
self.block_building_meter.start = Some(Instant::now());
self.block_building_meter.block_building_start = Some(Instant::now());
}

/// The duration of the current block building task if any.
pub(crate) fn finish_block_building_recording(&mut self) {
let duration = self.block_building_meter.start.take().map(|start| start.elapsed());
if let Some(duration) = duration {
self.block_building_meter.metric.block_building_duration.record(duration.as_secs_f64());
/// Finishes tracking the current block building task.
pub(crate) fn finish_block_building_recording(&mut self, block: Option<&ScrollBlock>) {
let now = Instant::now();
if let Some(t) = self.block_building_meter.block_building_start.take() {
let elapsed = now.duration_since(t).as_secs_f64();
self.block_building_meter.metric.all_block_building_duration.record(elapsed);

// Record only if it's not an empty block
let is_empty_block = block.map(|b| b.body.transactions.is_empty()).unwrap_or(true);
if !is_empty_block {
self.block_building_meter.metric.block_building_duration.record(elapsed);
}
}

if block.is_some() {
if let Some(t) = self.block_building_meter.last_block_building_time.replace(now) {
self.block_building_meter
.metric
.consecutive_block_interval
.record(now.duration_since(t).as_secs_f64());
}
}
}
}
Expand Down Expand Up @@ -104,13 +121,18 @@ pub(crate) struct ChainOrchestratorMetrics {
#[derive(Debug, Default)]
pub(crate) struct BlockBuildingMeter {
metric: BlockBuildingMetric,
start: Option<Instant>,
block_building_start: Option<Instant>,
last_block_building_time: Option<Instant>,
}

/// Block building related metric.
#[derive(Metrics, Clone)]
#[metrics(scope = "chain_orchestrator")]
pub(crate) struct BlockBuildingMetric {
/// The duration of the block building task.
/// The duration of the block building task without empty block
block_building_duration: Histogram,
/// The duration of the block building task for all blocks include empty block
all_block_building_duration: Histogram,
/// The duration of the block interval include empty block
consecutive_block_interval: Histogram,
}
Loading