From 240b43795ecad5e28e01764b304fe3a4ce2ece41 Mon Sep 17 00:00:00 2001 From: psy_inf Date: Thu, 1 Feb 2024 21:59:56 +0100 Subject: [PATCH] adding clang-tidy --- .github/workflows/checks.yml | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index bfff3e7e..f31ef606 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -17,8 +17,21 @@ jobs: lines-changed-only: true tidy-checks: -* version: 16 # todo find minimal viable version - - name: Fail fast?! - if: steps.linter.outputs.checks-failed > 0 - run: echo "Some files failed the linting checks!" - # for actual deployment - # run: exit 1 \ No newline at end of file +# - name: Fail fast?! +# if: steps.linter.outputs.checks-failed > 0 +# run echo "::warning file=app.js,line=1,col=5,endColumn=7::Missing semicolon" + + - name: Run clang-tidy-pr-comments action + uses: platisd/clang-tidy-pr-comments@v1 + with: + # The GitHub token (or a personal access token) + github_token: ${{ secrets.GITHUB_TOKEN }} + # The path to the clang-tidy fixes generated previously + clang_tidy_fixes: clang-fixes.yaml + # Optionally set to true if you want the Action to request + # changes in case warnings are found + request_changes: true + # Optionally set the number of comments per review + # to avoid GitHub API timeouts for heavily loaded + # pull requests + suggestions_per_comment: 10 \ No newline at end of file