compile under fedora 40

[cheese1]

config.status: include/gfx/config.h is unchanged
+ make -j2
make -C libgfx/src
make[1]: Entering directory '/builddir/build/BUILD/fireflies-2.08/libgfx/src'
g++ -c -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer   -I/builddir/build/BUILD/fireflies-2.08/libgfx/include -DHAVE_CONFIG_H  mat2.cxx
g++ -c -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer   -I/builddir/build/BUILD/fireflies-2.08/libgfx/include -DHAVE_CONFIG_H  mat3.cxx
In file included from mat2.cxx:9:
/builddir/build/BUILD/fireflies-2.08/libgfx/include/gfx/gfx.h:33:13: error: redeclaration of C++ built-in type ‘bool’ [-fpermissive]
   33 | typedef int bool;
      |             ^~~~
/builddir/build/BUILD/fireflies-2.08/libgfx/include/gfx/gfx.h:34:12: error: expected unqualified-id before ‘false’
   34 | const bool false = 0;
      |            ^~~~~
/builddir/build/BUILD/fireflies-2.08/libgfx/include/gfx/gfx.h:35:12: error: expected unqualified-id before ‘true’
   35 | const bool true = 1;
      |            ^~~~
In file included from mat3.cxx:9:
/builddir/build/BUILD/fireflies-2.08/libgfx/include/gfx/gfx.h:33:13: error: redeclaration of C++ built-in type ‘bool’ [-fpermissive]
   33 | typedef int bool;
      |             ^~~~
/builddir/build/BUILD/fireflies-2.08/libgfx/include/gfx/gfx.h:34:12: error: expected unqualified-id before ‘false’
   34 | const bool false = 0;
      |            ^~~~~
/builddir/build/BUILD/fireflies-2.08/libgfx/include/gfx/gfx.h:35:12: error: expected unqualified-id before ‘true’
   35 | const bool true = 1;
      |            ^~~~
make[1]: *** [../gfx-config:32: mat2.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/builddir/build/BUILD/fireflies-2.08/libgfx/src'
make[1]: *** [../gfx-config:32: mat3.o] Error 1
make: *** [Makefile:32: libgfx/src/libgfx.a] Error 2

[hartwork]

@cheese1 please make this a complete bug report against latest master and enough details to reproduce, the causing code is guarded at…

https://github.com/mpcomplete/fireflies/blob/d6fc80b7a156ccdf97042a9c20ed0eb8716c13c1/libgfx/include/gfx/gfx.h#L34C14-L38

…by HAVE_BOOL so we will need to understand why HAVE_BOOL is not defined in your very environment. (Release 2.08 compiles fine with GCC 12 in Gentoo.) Thanks in advance! 🙏

[cheese1]

master works.
i should have checked that beforehand, sorry for that.

maybe it would be a great opportunity to create a new versioned release?

[hartwork]

master works. i should have checked that beforehand, sorry for that.

@cheese1 I'd still be curious about how to reproduce the issue with 2.08 and what in post-2.08 master fixed it, e.g. so we can point others to the patch they need to cherry-pick or backport. I would throw git bisect at it, if it was failing on my own box, to find that answer. Are you maintaining a Fireflies distro RPM package somewhere?

maybe it would be a great opportunity to create a new versioned release?

master is not in a releasable state as far as I am concerned, e.g. see #23 in particular. And #18 (comment) gives me little hope for a soon usable >2.08 release.

[cheese1]

master works. i should have checked that beforehand, sorry for that.

@cheese1 I'd still be curious about how to reproduce the issue with 2.08 and what in post-2.08 master fixed it, e.g. so we can point others to the patch they need to cherry-pick or backport. I would throw git bisect at it, if it was failing on my own box, to find that answer. Are you maintaining a Fireflies distro RPM package somewhere?

@hartwork the same idea on my side :)
i think i will have the fix in some days (after some days off). if thats not a problem for you.

maybe it would be a great opportunity to create a new versioned release?

master is not in a releasable state as far as I am concerned, e.g. see #23 in particular. And #18 (comment) gives me little hope for a soon usable >2.08 release.

[hartwork]

@cheese1 a few days wait are not a problem, thanks in advance, see you! 👍