Add Event OnBeforeCustLedgerEntryModifyRecalledBill in Function RecallIssuedBill Cdu 12170 Italian Localization

[DamianoCastagna77]

Why do you need this change?

If a new field is added into the Customer Ledger Entry Table and it refers to Bill flow, it may be modified before the record update

Describe the request

Codeunit 12170 Recall Customer Bill

function RecallBill

repeat
   CustLedgEntry2.Get(IssuedCustomerBillLine."Customer Entry No.");
    if CustLedgEntry2."Customer Bill No." <> IssuedCustomerBillLine."Final Cust. Bill No." then
          Error(Text1130025, IssuedCustomerBillLine."Final Cust. Bill No.");
...             
    CustLedgEntry."Document Occurrence" := CustLedgEntry2."Document Occurrence";
    CustLedgEntry.Modify();
    InitGenJnlLine(BalanceAccountNo);
...
until IssuedCustomerBillLine.Next() = 0;

add Event

 CustLedgEntry."Document Occurrence" := CustLedgEntry2."Document Occurrence";
**OnBeforeCustLedgerEntryModifyRecalledBill(CustLedgEntry,CustLedgEntry2)**
  CustLedgEntry.Modify();

Event
OnBeforeCustLedgerEntryModifyRecalledBill(var CustomerLedgerEntry : Record "Customer Ledger Entry", CustomerLedgerEntry2 : record "Customer Ledger Entry)

[AleksandricMarko]

Hi @DamianoCastagna77,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include additional information about the performance implications.

📚 Extensibility Guidelines

Performance Warning - Event Inside Loop:

The proposed event location (before CustLedgEntry.Modify()) is inside a repeat...until loop that processes multiple customer bill lines. This means the event would fire for EVERY bill line being recalled, which can cause significant performance issues if subscribers perform database operations or external calls, especially when processing large numbers of bill lines.

Missing Information:

To properly evaluate this request, please provide:

1. Loop Necessity Justification: Why must the event fire on each iteration (for each bill line)? What specific operations need to happen per bill line that cannot be done before or after the loop?

2. Subscriber Operations: What operations will extensions perform in this event? (e.g., field updates, database reads, calculations)

3. Alternative Placements Evaluated: Have you considered these alternatives?

   • Event before the loop starts (line 56) to allow modifying setup/filters
   • Event after the loop completes (line 102) for post-processing
   • If per-line processing is essential, explain why alternatives don't work

Alternative Suggestions:

Based on typical extensibility patterns, consider whether one of these would satisfy your needs:

• Add event before the loop to allow modifying filters or setup logic
• Add event after the loop for post-processing all recalled bills
• If you truly need per-line processing, please provide detailed justification including expected volume and subscriber operations

Please update the issue with the missing details. We'll automatically re-analyze once updated.

[DamianoCastagna77]

Hi, thank for your update.
I temporary put my code into the OnRecallIssuedBillOnAfterInitGenJnlLine but I have to set filter for update a new field the I have on the Customer Ledger Entry.
Talking about performance is not a efficent code.

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Recall Customer Bill", OnRecallIssuedBillOnAfterInitGenJnlLine, '', false, false)]
local procedure "Recall Customer Bill_OnRecallIssuedBillOnAfterInitGenJnlLine"(var GenJournalLine: Record "Gen. Journal Line"; BillPostingGroup: Record "Bill Posting Group"; IssuedCustomerBillHeader: Record "Issued Customer Bill Header"; var IssuedCustomerBillLine: Record "Issued Customer Bill Line"; var CustLedgerEntry2: Record "Cust. Ledger Entry")
var
CustomerLedgerEntry: Record "Cust. Ledger Entry";
begin
CustomerLedgerEntry.Reset();
CustomerLedgerEntry.SetFilter("Customer No.", CustLedgerEntry2."Customer No.");
if CustLedgerEntry2."Allow Issue" then
CustomerLedgerEntry.SetRange("Document No.", CustLedgerEntry2."Bank Receipt Temp. No.");
CustomerLedgerEntry.SetRange("Document Type", CustLedgerEntry2."Document Type"::Payment);
CustomerLedgerEntry.SetRange("Document Type to Close", CustLedgerEntry2."Document Type");
CustomerLedgerEntry.SetFilter("Document No. to Close", CustLedgerEntry2."Document No.");
CustomerLedgerEntry.SetRange("Document Occurrence to Close", CustLedgerEntry2."Document Occurrence");
CustomerLedgerEntry.SetRange(Open, true);
CustomerLedgerEntry.FindFirst();
// Modify my fields
CustomerLedgerEntry.MyField := true;

    CustomerLedgerEntry.Modify();

What I need is to have the possibility to Update other fields based on filters that are already set for customer ledger entry.

If I have to use an event outside the loop I will have to set filters on Bill Line and then for every bill line set filters on customer legder entry and, at last , update my fields.