[Event Request] Codeunit 181 "Copy Gen. Journal Mgt." - procedure CheckIfCanBeCopied()

[APsVallelonga]

Why do you need this change?

Hello,
We would like to request a new event in the CheckIfCanBeCopied procedure of Codeunit 181 "Copy Gen. Journal Mgt."
This would allow us to bypass the standard checks and implement our own custom logic.

New Event and Code:

local procedure CheckIfCanBeCopied(var PostedGenJournalLine: Record "Posted Gen. Journal Line")
  var
      GLRegister: Record "G/L Register";
     // New Variable
     IsHandled: Boolean;
  begin
      if PostedGenJournalLine.FindSet() then
          repeat
         IsHandled := false;
       //New Event
       OnBeforeCheckIfCanBeCopied(PostedGenJournalLine,IsHandled);
       //New Code
           if not IsHandled then begin 
              GLRegister.Get(PostedGenJournalLine."G/L Register No.");
              CheckCustomerEntries(GLRegister);
              CheckVendorEntries(GLRegister);
          end;
          until PostedGenJournalLine.Next() = 0;

      OnAfterCheckIfCanBeCopied(PostedGenJournalLine);
  end;

Signature:

 [IntegrationEvent(false, false)]
  local procedure OnBeforeCheckIfCanBeCopied(var PostedGenJournalLine: Record "Posted Gen. Journal Line"; var IsHandled: Boolean)
  begin
  end;

Thank You,
Luca

Describe the request

The event would enable us to bypass the checks on the GLRegister fields in the CheckIfCanBeCopied procedure.
Internal work item: AB#598044

[AndreasHans]

Please see the guidelines for new IsHandled events and update the description

[AndersLarsenMicrosoft]

@APsVallelonga did you read the comment from Andreas?

[gpintaudi]

Hi @AndreasHans @AndersLarsenMicrosoft, as a colleague of @APsVallelonga, I will update the issue with missing information.

Problem Statement
We have solution for posting Simulation G/L Entries. Starting from a General Journal batch (marked with a Simulation flag) we post entries in a Simulation G/L Entry table instead of the standard G/L Entry table.
Some of our customers are using the option to Copy General Journal lines to Posted General Journal lines. On The Posted General Journal page there is an action to copy back posted lines to general journal. This action calls the CopyToGenJournal procedure and then the CheckIfCanBeCopied local procedure which is the subject of this issue. This last procedure performs checks on Posted Gen Journal lines assuming there is G/L Register. But within our solution we have created our own Simulation G/L Register since we are not posting to G/L but to Simulation G/L. Therefore we are not able actually to use the feature to copy Posted G/L to Gen Journal.

Proposed code change
The one posted by @APsVallelonga in the initial description. The idea is to have an IsHandled event to skip standard check and let us perform our own checks.
Alternative proposal is to add the IsHandled event in CopyToGenJournal procedure, avoiding the call to CheckIfCanBeCopied procedure.

Alternatives evaluated
The possible alternative is to create our own action in the Posted Gen Journal page to perform same task of the standard one. That means for us to duplicate standard procedure CopyToGenJournal, which has more than one reference.

Performance considerations
We don't see any additional impact on performance, as we will subscribe the IsHandled event by replacing GLRegister.Get with our SimulationGLRegister.Get function if the record is related to our Simulation feature posting.

Data sensitivity review
The event will only expose the Posted Gen Journal record.

Multi‑extension interaction
An extension that subscribe to this event should set the IsHandled to true in order to avoid the multi-extension interaction risk.

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 45860.