UnlockedKeyring::items() should return `UnlockedItem`s

[sophie-h]

The docs say

Retrieve the list of available UnlockedItems.

If items cannot be decrypted, InvalidItemErrors are returned for them instead of UnlockedItems.

oo7/client/src/file/unlocked_keyring.rs

Line 251 in c6e3f41

pub async fn items(&self) -> Result<Vec<Result<Item, InvalidItemError>>, Error> {

but then, it returns Items

[bilelmoussaoui]

That link points to LockedKeyring btw. The UnlockedKeyring does return an UnlockedItem in a Item::Unlocked, mostly to simplify code in the wrapper keyring that wouldn't have to do a bunch of mapping for every case.

[bilelmoussaoui]

So i suggest I update the docs or would that be difficult to use for your use case?

[sophie-h]

That link points to LockedKeyring btw.

Updated the the link

The UnlockedKeyring does return an UnlockedItem in a Item::Unlocked, mostly to simplify code in the wrapper keyring that wouldn't have to do a bunch of mapping for every case.

I don't think that makes sense. If it is unlocked, then return an Unlocked type. Otherwise you have to do all the error handling twice, and once for an error that cannot occur. Just implement into() or something.

[bilelmoussaoui]

If you have time to review #417, i would appreciate that.