From b0594d8145ac9e3617e46fd9394f8545ecc55222 Mon Sep 17 00:00:00 2001 From: Googler Date: Fri, 20 Feb 2026 15:39:58 -0800 Subject: [PATCH] Integrate LLVM at llvm/llvm-project@fbfe23e16d5e Updates LLVM usage to match [fbfe23e16d5e](https://github.com/llvm/llvm-project/commit/fbfe23e16d5e) PiperOrigin-RevId: 873103325 --- bazel/llvm.bzl | 2 +- lifetime_analysis/test/control_flow.cc | 12 +++--------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/bazel/llvm.bzl b/bazel/llvm.bzl index aedd6f32b..f1aa465d0 100644 --- a/bazel/llvm.bzl +++ b/bazel/llvm.bzl @@ -53,7 +53,7 @@ def _llvm_loader_repository(repository_ctx): executable = False, ) -LLVM_COMMIT_SHA = "b20d7d0278059735bb8eb538ac51e13b58895c1a" +LLVM_COMMIT_SHA = "fbfe23e16d5e49c9decccc981a4716e7cf81d242" def llvm_loader_repository_dependencies(): # This *declares* the dependency, but it won't actually be *downloaded* unless it's used. diff --git a/lifetime_analysis/test/control_flow.cc b/lifetime_analysis/test/control_flow.cc index 0b4f35401..18b5614cd 100644 --- a/lifetime_analysis/test/control_flow.cc +++ b/lifetime_analysis/test/control_flow.cc @@ -43,11 +43,7 @@ TEST_F(LifetimeAnalysisTest, ReturnRefArgumentWithConditionalOperator) { LifetimesAre({{"get_lesser_of", "a, a -> a"}})); } -TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWorkSometimes) { - // This test documents that we do understand the control flow resulting from - // exceptions in some limited circumstances. However, this is not true in the - // general case -- see the test ControlFlowExceptionsNotSupportedInGeneral -- - // and it's a non-goal to add support for this. +TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWithUnconditionalThrow) { EXPECT_THAT(GetLifetimes(R"( int* target(int* a, int* b) { try { @@ -61,9 +57,7 @@ TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWorkSometimes) { LifetimesAre({{"target", "a, b -> b"}})); } -TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsNotSupportedInGeneral) { - // This test documents that we do not in general treat the control flow - // resulting from exceptions correctly; changing this is a non-goal. +TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWithUnknownControlFlow) { EXPECT_THAT(GetLifetimes(R"( void may_throw() { throw 42; @@ -77,7 +71,7 @@ TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsNotSupportedInGeneral) { } } )"), - LifetimesContain({{"target", "a, b -> a"}})); + LifetimesContain({{"target", "a, a -> a"}})); } TEST_F(LifetimeAnalysisTest, DoublePointerWithConditionalAssignment) {