-
Notifications
You must be signed in to change notification settings - Fork 61
Open
Labels
maintainer-scrapRough notes for AI implementation. Not for human eyes.Rough notes for AI implementation. Not for human eyes.
Description
Summary
Follow-up from PR #1012 code review. Minor test coverage improvements suggested for validateAndSanitizeMatcher in opencode-hooks.
Tasks
- Add test for backslash-containing matchers (e.g.,
\bWrite\b) to verify double-escaping produces correct generated code - Add test for NUL byte (
\0) stripping (currently\n/\rare tested but\0is not) - (Optional) Consider extracting the control character set (
\n,\r,\0) into a shared constant betweenhasControlCharsinhooks.tsandvalidateAndSanitizeMatcherinopencode-hooks.tsto prevent drift
Context
- PR fix: opencode-hooks followup - gitignore, matcher sanitization, tests #1012: fix: opencode-hooks followup - gitignore, matcher sanitization, tests
- These are non-blocking improvements identified during code review
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
maintainer-scrapRough notes for AI implementation. Not for human eyes.Rough notes for AI implementation. Not for human eyes.