Replace time.Sleep in tests with deterministic synchronization#1722
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 13, 2026
Merged
Replace time.Sleep in tests with deterministic synchronization#1722dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
Use require.Eventually, time.AfterFunc, and channel synchronization instead of fixed time.Sleep calls to make tests faster and less flaky. - telemetry: poll mockHTTP.GetRequestCount() with require.Eventually - fake/proxy: use channel write and require.Eventually for sync points - runtime/fallback: use time.AfterFunc for context cancel, require.Eventually for cooldown expiry - tui/styles: poll atomic callback counter with require.Eventually Assisted-By: cagent
There was a problem hiding this comment.
Review Summary
✅ No issues found!
The changes look good. The PR successfully replaces fixed time.Sleep calls with deterministic synchronization patterns:
- ✅ pkg/fake/proxy_test.go: Channel write +
require.Eventuallyfor proper sync - ✅ pkg/runtime/fallback_test.go:
time.AfterFunc+require.Eventuallyfor clean timing control - ✅ pkg/runtime/runtime_test.go: Improved comment explaining timing-based negative test
- ✅ pkg/telemetry/telemetry_test.go: All
time.Sleepreplaced withrequire.Eventuallypolling - ✅ pkg/tui/styles/theme_watcher_test.go: Proper atomic polling with
require.Eventually
All require.Eventually calls use correct syntax, appropriate timeouts, and proper thread-safe operations. No race conditions or synchronization issues detected.
Member
|
Can't we use |
Member
Author
|
@rumpl It's coming in the next batch (where it's really useful) |
derekmisler
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use require.Eventually, time.AfterFunc, and channel synchronization instead of fixed time.Sleep calls to make tests faster and less flaky.
Assisted-By: cagent