-
Notifications
You must be signed in to change notification settings - Fork 36
Description
Description of the Bug
As per
chargebee-python/chargebee/main.py
Line 14 in d70fc00
| ca_cert_path = os.path.join(os.path.dirname(__file__), "ssl", "ca-certs.crt") |
In my not-so-humble opinion this violates the expectation of least surprise: on correctly configured systems the certificate bundles are present and reachable by python code. By pushing this stuff into a specific package you tie the ability of the system to make connections to the outside world to a specific version of chargebee and you tie the upgrade-cycle of your codebase (e.g. with pinned packages) to certificate validity.
There is a reason all the other request-making packages in the python ecosystem don't do this.
Now, I understand why this choice was made (it allows you to package something that "just works") but given that it's the WrongChoice(TM) you should at least create a point of configuration such that one can point the chargebee client either to the system certificate bundles, or just tell it to do whatever the underlying library (e.g. requests) would normally do.
Additional context
#60 is a direct consequence of this problem (and the suggested solution of "just upgrade") proves this