From ad2a5cc3b7a4d79f25f6ac25f35a9176b4e9ed2d Mon Sep 17 00:00:00 2001 From: Parker Bibus Date: Wed, 18 Feb 2026 16:22:49 -0800 Subject: [PATCH] Add NoResetOnClose=true to PostgreSQL connection strings missing it Commit 36ab8b94 removed Multiplexing=true and tightened Program.cs to require NoResetOnClose=true, but missed adding it to connection strings that previously relied on Multiplexing=true to pass the check. Fixes Fortunes, Fortunes EF, and Fortune Dapper failures in the benchmarks-ci-01 Trends Database pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- scenarios/database.benchmarks.yml | 2 +- scenarios/mono.benchmarks.yml | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/scenarios/database.benchmarks.yml b/scenarios/database.benchmarks.yml index 3c4a39986..0bb5a36eb 100644 --- a/scenarios/database.benchmarks.yml +++ b/scenarios/database.benchmarks.yml @@ -23,7 +23,7 @@ jobs: arguments: "--nonInteractive true --scenarios {{scenario}} --urls {{serverScheme}}://{{serverAddress}}:{{serverPort}} --server {{server}} --kestrelTransport {{transport}} --protocol {{protocol}}" environmentVariables: database: PostgresQL - connectionString: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=18;Enlist=false;Max Auto Prepare=4 + connectionString: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=18;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 postgresql: source: diff --git a/scenarios/mono.benchmarks.yml b/scenarios/mono.benchmarks.yml index ac557bf57..b7202f6fa 100644 --- a/scenarios/mono.benchmarks.yml +++ b/scenarios/mono.benchmarks.yml @@ -166,7 +166,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -184,7 +184,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -202,7 +202,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -220,7 +220,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -418,7 +418,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -435,7 +435,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -452,7 +452,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: @@ -469,7 +469,7 @@ scenarios: - "/p:IsDatabase=true" environmentVariables: database: PostgreSQL - connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4 + connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4 load: job: wrk variables: