Tidy up pcm format handling in some places#3063
Open
nift4 wants to merge 1 commit intoandroidx:mainfrom
Open
Conversation
Contributor
nift4
commented
Feb 10, 2026
nift4
commented
- refactor a few usages that manually handle all pcm formats to the Util methods that already exist.
- now that we have ENCODING_PCM_DOUBLE, introduce a helper for it. we get wav/mka/mp4 64-bit float support for free. (test files created from other test files in this repo included.)
- after Parse ALAC bit depth from initialization data #2738 common alac files had bit depth populated correctly, but I recently learnt that there is also 20-bit alac files (you can create them with afconvert). it doesn't make any sense and it's very complex to handle 20-bit PCM in the media3 pipelines because one byte may belong to multiple samples, but we also don't need to. create an encoding used to flag that this file is 20-bit PCM in the ALAC Format object, but expect decoders to output 24-bit or 16-bit PCM instead (playback will otherwise fail). (test file created from other test files in this repo included.)
- Adds missing pcm formats to ToFloatPcmAudioProcessor, incl tests.
- refactor a few usages that manually handle all pcm formats to the Util methods that already exist. - now that we have ENCODING_PCM_DOUBLE, introduce a helper for it. we get wav/mka/mp4 64-bit float support for free. (test files created from other test files in this repo included.) - after androidx#2738 common alac files had bit depth populated correctly, but I recently learnt that there is also 20-bit alac files (you can create them with afconvert). it doesn't make any sense and it's very complex to handle 20-bit PCM in the media3 pipelines because one byte may belong to multiple samples, but we also don't need to. create an encoding used to flag that this file is 20-bit PCM in the ALAC Format object, but expect decoders to output 24-bit or 16-bit PCM instead (playback will otherwise fail). (test file created from other test files in this repo included.) - Adds missing pcm formats to ToFloatPcmAudioProcessor, incl tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.