Skip to content

Unable to detect uppercase "DOCOMO" and lowercase "docomo" #2

@ymizuno-sun

Description

@ymizuno-sun

Hello,

The system fails to detect devices listed when the case of "DOCOMO" is different (uppercase vs. lowercase).

I attempted to add the following device to the default list:

31,0,docomo,SO-41B,Sony,Xperia Ace II,3982-3985MB,Phone,Mediatek MT6765,Imagination Tech PowerVR GE8320 (680 MHz),720x1496,300,arm64-v8a;armeabi;armeabi-v7a,30;31;33,0%0%0%0%

I identified that the issue originates from a case-sensitive check in vkquality_matching.cpp:

if (brand_view == brand && device_view == device) {

After modifying the code to perform a case-insensitive comparison, the device was recognized and operated correctly.

if (to_lower(brand_view) == to_lower(brand) && device_view == device) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions