Add support for thought signatures and thought tokens#216
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #216 +/- ##
============================================
+ Coverage 87.45% 87.61% +0.16%
- Complexity 1194 1209 +15
============================================
Files 60 60
Lines 3858 3924 +66
============================================
+ Hits 3374 3438 +64
- Misses 484 486 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gziolo
left a comment
There was a problem hiding this comment.
Looks good — clean, backward compatible, well-tested. All checks pass locally (tests, PHPCS clean, PHPStan clean). Left a minor nit on test values.
|
Minor nit on $tokenUsage = new TokenUsage(100, 50, 250, 100);
|
This PR does two decoupled but related things:
thoughtchannel message parts. Several models will include thought signatures on actual content parts that (I suppose) involved thinking behind the scenes. For example, function calls commonly include them, but even images in multimodal output models can include them.Both changes are fully optional and therefore backward compatible. However, once this is launched, we should update the provider implementations to support both where applicable - especially critical for point 1.