From e5bab8431b2dffca36fb76e04c92d5af71882742 Mon Sep 17 00:00:00 2001 From: m2rt Date: Mon, 9 Mar 2026 15:59:21 +0200 Subject: [PATCH] fix(tooltip): removed aria-expanded attribute #319 --- .../tooltip-trigger.component.spec.ts | 15 +-------------- .../tooltip-trigger/tooltip-trigger.component.ts | 6 +----- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.spec.ts b/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.spec.ts index 608c9db6d..9246801b6 100644 --- a/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.spec.ts +++ b/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.spec.ts @@ -6,7 +6,6 @@ import { Renderer2 } from "@angular/core"; class MockTooltipComponent { descriptionId = "mock-tooltip-id"; - isOpen = jest.fn(() => false); isContentHovered = jest.fn(() => false); timeoutDelay = jest.fn(() => 100); hideTimeout?: ReturnType; @@ -227,25 +226,13 @@ describe("TooltipTriggerComponent", () => { expect(btn.getAttribute("tabindex")).toBe("2"); }); - it("should set ARIA attributes on interactive element when closed", () => { + it("should set aria-describedby on interactive element", () => { hostEl.innerHTML = ``; const btn = hostEl.querySelector("button")!; component.ngAfterContentChecked(); fixture.detectChanges(); expect(btn.getAttribute("aria-describedby")).toBe("mock-tooltip-id"); - expect(btn.getAttribute("aria-expanded")).toBe("false"); - }); - - it("should set aria-expanded to true when tooltip is open", () => { - tooltip.isOpen = jest.fn(() => true); - hostEl.innerHTML = ``; - const btn = hostEl.querySelector("button")!; - component.ngAfterContentChecked(); - fixture.detectChanges(); - - expect(btn.getAttribute("aria-describedby")).toBe("mock-tooltip-id"); - expect(btn.getAttribute("aria-expanded")).toBe("true"); }); }); }); diff --git a/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts b/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts index cce6165bd..0ca55f61e 100644 --- a/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts +++ b/tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts @@ -31,11 +31,7 @@ export class TooltipTriggerComponent implements AfterContentChecked { const element = this.interactiveElement(); if (!element) return; - const descriptionId = this.tooltip.descriptionId; - const isOpen = this.tooltip.isOpen(); - - element.setAttribute("aria-describedby", descriptionId); - element.setAttribute("aria-expanded", String(isOpen)); + element.setAttribute("aria-describedby", this.tooltip.descriptionId); }); }