-
Notifications
You must be signed in to change notification settings - Fork 220
Open
Description
Summary
UI auth config still contains insecure fallback secrets and effectively indefinite sessions.
Why this matters
- Hardcoded default secrets can be exploited if deployed unchanged.
- 100-year session lifetime weakens account/session security posture.
Evidence
sirius-ui/src/server/auth.ts:- fallback
NEXTAUTH_SECRETvalue (change-this-secret-in-production-please) session.maxAgeset to ~100 years
- fallback
sirius-ui/src/env.mjs:- fallback auth/client values remain present
Current behavior
- app can run with insecure fallback secrets
- session duration is effectively indefinite
Expected behavior
- production must require strong explicit secrets
- no insecure fallback defaults for auth secrets
- session lifetime should be bounded (e.g., 24h-7d depending on policy)
Proposed fix
- Remove insecure fallback for
NEXTAUTH_SECRETin production paths. - Enforce startup validation for required auth secrets.
- Reduce
session.maxAgeto policy-approved value. - Document secure secret generation/rotation procedure.
- Add test coverage for missing secret rejection and session TTL policy.
Acceptance criteria
- Production startup fails when auth secrets are missing/placeholder.
- No hardcoded insecure secret fallback used in production paths.
- Session maxAge is reduced to approved policy value.
- Auth docs updated with required env vars and secret handling.
Release target
1.0.1 security hardening
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels