-
Notifications
You must be signed in to change notification settings - Fork 18
Description
I think we need to do a top-level renaming of the creates, features, Node implementations, etc. This will be a major breaking change for users so I want to get it right this time and not touch it.
Rename the sub-crates, features, and modules as:
- roslibrust_ros1 => roslibrust_ros1_tcpros
- roslibrust_zenoh => roslibrust_ros1_zenoh
- roslibrust_ros2 => rosliburst_ros2_zenoh
I'm considering this renaming, but want other folks to weigh in:
All the crates have "NodeHandle" of some kind, but all with different names: [MockRos, ZenohClient, ClientHandle, etc.]. I propose re-naming all of these to be NodeHandle in their respective crate instead of having unique name. I think previously I was resistant to this as it makes navigating the repository harder, but I think to end-users will find it more logical if they all have a common name?
If we do this we should also re-name Subscriber, Publisher, ServiceServer, and ServiceClient to be consistently named across all the backends as well.