bug: Inconsistent User Role-based UI Element Visibility

[ottodevs]

👤 User Story

As a user of the Pool application, I want to see only the UI elements relevant to my role so that I can interact with the application securely and without confusion.

📝 Bug Description

There are inconsistencies in the visibility of UI elements based on user roles. Some elements, particularly admin functions like the Create Pool button, may be visible to unauthorized users. This issue affects the security and user experience of the application.

🔄 Steps to Reproduce

1. Log in as a non-admin user.
2. Navigate through various pages of the application, particularly the main dashboard or pool listing page.
3. Observe if any admin-only elements (e.g., Create Pool button) are visible.
4. If possible, attempt to interact with these elements.
5. Repeat the process with different user roles to identify any inconsistencies.

🎯 Expected Behavior

• UI elements should be consistently displayed or hidden based on the user's role.
• Admin-only functions (like the Create Pool button) should only be visible to users with admin privileges.
• Non-admin users should not see or be able to interact with admin-specific elements.
• The application should maintain these role-based visibility rules across all components and pages.

📸 Screenshots or GIFs

No response

📘 Additional Context

• This issue is critical for preventing unauthorized access to admin functions.
• The problem potentially affects various components throughout the application, with special attention needed for the Create Pool button visibility.
• Implementing proper role checks may be necessary, potentially using the existing authentication system.
• Consider adding automated tests to ensure correct visibility of elements based on user roles.
• This fix will enhance both the security and user experience of the application.

🔗 Related Issues

No response

👥 Mention

No response

[dantgw]

I didn't manage to replicate the issue. I'm not sure if this issue was present in the past, and @ottodevs has already fixed the issue.

Scenarios I've tried

• Connecting to the app using multiple accounts (1 admin, 1 non-admin) at the same time. Navigating through various pages (profile, pools, pool/54) on non-admin. Did not observe the Create Pool button showing on non-admin.
• Different connection methods (Coinbase Wallet and Metamask).
• Connecting to both localhost and app.poolparty.cc sites at the same time with admin and non-admin accounts.

I've added a test case for checking the visibility of the 'Create Pool' button.