From 3cd5cd2a54d095880ae0a02be0de37f798e0be9b Mon Sep 17 00:00:00 2001 From: erwan-joly Date: Thu, 15 Jan 2026 08:56:06 +1300 Subject: [PATCH] fixes --- .../Login/NoS0575PacketHandlerTests.cs | 6 +++++- .../Login/NoS0577PacketHandlerTests.cs | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/test/NosCore.PacketHandlers.Tests/Login/NoS0575PacketHandlerTests.cs b/test/NosCore.PacketHandlers.Tests/Login/NoS0575PacketHandlerTests.cs index 22568a205..d9eec6fa9 100644 --- a/test/NosCore.PacketHandlers.Tests/Login/NoS0575PacketHandlerTests.cs +++ b/test/NosCore.PacketHandlers.Tests/Login/NoS0575PacketHandlerTests.cs @@ -32,6 +32,7 @@ using NosCore.GameObject.InterChannelCommunication.Hubs.PubSub; using NosCore.GameObject.Networking.ClientSession; using NosCore.GameObject.Services.LoginService; +using NosCore.Networking; using NosCore.Networking.SessionRef; using NosCore.PacketHandlers.Login; using NosCore.Packets.ClientPackets.Login; @@ -54,6 +55,7 @@ public class NoS0575PacketHandlerTests private NoS0575PacketHandler? _noS0575PacketHandler; private ClientSession? _session; private Mock? _channelHub; + private SessionRefHolder? _sessionRefHolder; [TestInitialize] public async Task SetupAsync() @@ -64,10 +66,12 @@ public async Task SetupAsync() _authHttpClient = new Mock(); _pubSubHub = TestHelpers.Instance.PubSubHub; _loginConfiguration = Options.Create(new LoginConfiguration()); + _sessionRefHolder = new SessionRefHolder(); _channelHub = new Mock(); + _sessionRefHolder![_session!.Channel!.Id] = new RegionTypeMapping(_session.SessionId, RegionType.EN); _noS0575PacketHandler = new NoS0575PacketHandler(new LoginService(_loginConfiguration, TestHelpers.Instance.AccountDao, - _authHttpClient.Object, _pubSubHub.Object, _channelHub!.Object, TestHelpers.Instance.CharacterDao, new SessionRefHolder()), + _authHttpClient.Object, _pubSubHub.Object, _channelHub!.Object, TestHelpers.Instance.CharacterDao, _sessionRefHolder!), _loginConfiguration, Logger, TestHelpers.Instance.LogLanguageLocalizer); } diff --git a/test/NosCore.PacketHandlers.Tests/Login/NoS0577PacketHandlerTests.cs b/test/NosCore.PacketHandlers.Tests/Login/NoS0577PacketHandlerTests.cs index af5bb9c65..8dea10b5c 100644 --- a/test/NosCore.PacketHandlers.Tests/Login/NoS0577PacketHandlerTests.cs +++ b/test/NosCore.PacketHandlers.Tests/Login/NoS0577PacketHandlerTests.cs @@ -34,6 +34,7 @@ using NosCore.GameObject.InterChannelCommunication.Hubs.PubSub; using NosCore.GameObject.Networking.ClientSession; using NosCore.GameObject.Services.LoginService; +using NosCore.Networking; using NosCore.Networking.SessionRef; using NosCore.PacketHandlers.Login; using NosCore.Packets.ClientPackets.Login; @@ -61,6 +62,7 @@ public class NoS0577PacketHandlerTests private NoS0577PacketHandler? _noS0577PacketHandler; private ClientSession? _session; private Mock? _channelHub; + private SessionRefHolder? _sessionRefHolder; private static string GuidToToken(string token) { @@ -72,13 +74,15 @@ public async Task SetupAsync() { await TestHelpers.ResetAsync().ConfigureAwait(false); _channelHub = new Mock(); + _sessionRefHolder = new SessionRefHolder(); _session = await TestHelpers.Instance.GenerateSessionAsync().ConfigureAwait(false); + _sessionRefHolder[_session.Channel!.Id] = new RegionTypeMapping(_session.SessionId, RegionType.EN); _authHttpClient.Setup(s => s.GetAwaitingConnectionAsync(It.IsAny(), It.IsAny(), It.IsAny())).ReturnsAsync((string a, string b, int c) => (string?)((new OkObjectResult(_session.Account.Name)).Value)); _noS0577PacketHandler = new NoS0577PacketHandler(new LoginService(_loginConfiguration, TestHelpers.Instance.AccountDao, - _authHttpClient.Object, _pubSubHub.Object, _channelHub.Object, TestHelpers.Instance.CharacterDao, new SessionRefHolder())); + _authHttpClient.Object, _pubSubHub.Object, _channelHub.Object, TestHelpers.Instance.CharacterDao, _sessionRefHolder)); SessionFactory.Instance.AuthCodes[_tokenGuid] = _session.Account.Name; SessionFactory.Instance.ReadyForAuth.Clear(); }